Re: [PATCH 1/2] kernel-shark: Execute kshark-record from same dir as kshark-su-record

["Yordan Karadzhov (VMware)" <y.karadz@gmail.com>]

On 24.07.19 г. 1:50 ч., Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> 
> Do not trust the PATH environment variable (and in fact that may not even be
> available with the pkexec). Instead, use the same path as kshark-su-record
> to find kshark-record. They should always be together anyway.
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
>   kernel-shark/bin/kshark-su-record | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel-shark/bin/kshark-su-record b/kernel-shark/bin/kshark-su-record
> index 2477045f1710..7faff1cb3339 100755
> --- a/kernel-shark/bin/kshark-su-record
> +++ b/kernel-shark/bin/kshark-su-record
> @@ -5,4 +5,5 @@ then
>       xhost +si:localuser:root &>/dev/null
>   fi
>   
> -pkexec kshark-record -o ${PWD}/trace.dat
> +THIS_DIR=`dirname $0`
> +pkexec ${THIS_DIR}/kshark-record -o ${PWD}/trace.dat
> 

I just realized that there is one problem with the patch. With this 
modification, you can use only the installed version of the script (so 
you more or less depend on PATH).

This will work:
  kshark-su-record

This will work as well:
  /usr/local/bin/kshark-su-record

However this will not work:
  kernel-shark/bin/kshark-su-record

because you are trying to start with pkexec an executable from your $HOME

Thanks!
Yordan