Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] trace-cmd: Generate proper soname
@ 2019-07-25  1:48 Patrick McLean
  2019-07-25  1:59 ` Steven Rostedt
  2019-07-25 12:49 ` Steven Rostedt
  0 siblings, 2 replies; 4+ messages in thread
From: Patrick McLean @ 2019-07-25  1:48 UTC (permalink / raw)
  To: linux-trace-devel

From: Patrick McLean <patrick.mclean@sony.com>

The previous soname patch was an earlier version that included the full
path to the build output as the soname (not sure how that happened).
This just uses the basename as the soname, so ld will be able to
properly find the library.
---
 scripts/utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/utils.mk b/scripts/utils.mk
index 9eb127d..98d7b3c 100644
--- a/scripts/utils.mk
+++ b/scripts/utils.mk
@@ -54,7 +54,7 @@ do_build_static_lib =				\
 
 do_compile_shared_library =			\
 	($(print_shared_lib_compile)		\
-	$(CC) --shared $^ -Wl,-soname,$@ -o $@)
+	$(CC) --shared $^ -Wl,-soname,$(@F) -o $@)
 
 do_compile_plugin_obj =				\
 	($(print_plugin_obj_compile)		\
-- 
2.22.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] trace-cmd: Generate proper soname
  2019-07-25  1:48 [PATCH] trace-cmd: Generate proper soname Patrick McLean
@ 2019-07-25  1:59 ` Steven Rostedt
  2019-07-25 12:49 ` Steven Rostedt
  1 sibling, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2019-07-25  1:59 UTC (permalink / raw)
  To: Patrick McLean; +Cc: linux-trace-devel

On Wed, 24 Jul 2019 18:48:08 -0700
Patrick McLean <chutzpah@gentoo.org> wrote:

> From: Patrick McLean <patrick.mclean@sony.com>
> 
> The previous soname patch was an earlier version that included the full
> path to the build output as the soname (not sure how that happened).
> This just uses the basename as the soname, so ld will be able to
> properly find the library.

Ah, so now I need to release a 2.8.4?

Thanks, ;-)

I'll wait till Friday before adding a 2.8.4.

-- Steve

> ---
>  scripts/utils.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/utils.mk b/scripts/utils.mk
> index 9eb127d..98d7b3c 100644
> --- a/scripts/utils.mk
> +++ b/scripts/utils.mk
> @@ -54,7 +54,7 @@ do_build_static_lib =				\
>  
>  do_compile_shared_library =			\
>  	($(print_shared_lib_compile)		\
> -	$(CC) --shared $^ -Wl,-soname,$@ -o $@)
> +	$(CC) --shared $^ -Wl,-soname,$(@F) -o $@)
>  
>  do_compile_plugin_obj =				\
>  	($(print_plugin_obj_compile)		\


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] trace-cmd: Generate proper soname
  2019-07-25  1:48 [PATCH] trace-cmd: Generate proper soname Patrick McLean
  2019-07-25  1:59 ` Steven Rostedt
@ 2019-07-25 12:49 ` Steven Rostedt
  2019-07-25 17:08   ` Patrick McLean
  1 sibling, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2019-07-25 12:49 UTC (permalink / raw)
  To: Patrick McLean; +Cc: linux-trace-devel

On Wed, 24 Jul 2019 18:48:08 -0700
Patrick McLean <chutzpah@gentoo.org> wrote:

> From: Patrick McLean <patrick.mclean@sony.com>
> 
> The previous soname patch was an earlier version that included the full
> path to the build output as the soname (not sure how that happened).
> This just uses the basename as the soname, so ld will be able to
> properly find the library.

Hi Patrick,

You forgot to add the Signed-off-by, can you reply to this with one.
Thanks. I can't add it without it.

-- Steve

> ---
>  scripts/utils.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/utils.mk b/scripts/utils.mk
> index 9eb127d..98d7b3c 100644
> --- a/scripts/utils.mk
> +++ b/scripts/utils.mk
> @@ -54,7 +54,7 @@ do_build_static_lib =				\
>  
>  do_compile_shared_library =			\
>  	($(print_shared_lib_compile)		\
> -	$(CC) --shared $^ -Wl,-soname,$@ -o $@)
> +	$(CC) --shared $^ -Wl,-soname,$(@F) -o $@)
>  
>  do_compile_plugin_obj =				\
>  	($(print_plugin_obj_compile)		\


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] trace-cmd: Generate proper soname
  2019-07-25 12:49 ` Steven Rostedt
@ 2019-07-25 17:08   ` Patrick McLean
  0 siblings, 0 replies; 4+ messages in thread
From: Patrick McLean @ 2019-07-25 17:08 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linux-trace-devel

On Thu, 25 Jul 2019 08:49:32 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 24 Jul 2019 18:48:08 -0700
> Patrick McLean <chutzpah@gentoo.org> wrote:
> 
> > From: Patrick McLean <patrick.mclean@sony.com>
> > 
> > The previous soname patch was an earlier version that included the
> > full path to the build output as the soname (not sure how that
> > happened). This just uses the basename as the soname, so ld will be
> > able to properly find the library.  
> 
> Hi Patrick,
> 
> You forgot to add the Signed-off-by, can you reply to this with one.
> Thanks. I can't add it without it.
> 
My apologies.

> -- Steve
> 

Signed-off-by: Patrick McLean <patrick.mclean@sony.com>
> > ---
> >  scripts/utils.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/utils.mk b/scripts/utils.mk
> > index 9eb127d..98d7b3c 100644
> > --- a/scripts/utils.mk
> > +++ b/scripts/utils.mk
> > @@ -54,7 +54,7 @@ do_build_static_lib
> > =				\ 
> >  do_compile_shared_library =			\
> >  	($(print_shared_lib_compile)		\
> > -	$(CC) --shared $^ -Wl,-soname,$@ -o $@)
> > +	$(CC) --shared $^ -Wl,-soname,$(@F) -o $@)
> >  
> >  do_compile_plugin_obj =				\
> >  	($(print_plugin_obj_compile)		\  
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25  1:48 [PATCH] trace-cmd: Generate proper soname Patrick McLean
2019-07-25  1:59 ` Steven Rostedt
2019-07-25 12:49 ` Steven Rostedt
2019-07-25 17:08   ` Patrick McLean

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org linux-trace-devel@archiver.kernel.org
	public-inbox-index linux-trace-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox