From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com
Subject: Re: [PATCH 1/3] kernel-shark: Show warning message when running as Root
Date: Fri, 9 Aug 2019 09:19:14 -0400 [thread overview]
Message-ID: <20190809091914.75f553b2@gandalf.local.home> (raw)
In-Reply-To: <20190809080623.7548-2-y.karadz@gmail.com>
On Fri, 9 Aug 2019 11:06:21 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> Running the KernelShark GUI with Root privileges is not recommended due
> to security reasons. The user will be allowed to continue on its own risk.
>
> Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204475
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
> kernel-shark/src/KsMainWindow.cpp | 28 ++++++++++++++++++++++++++++
> kernel-shark/src/KsMainWindow.hpp | 2 ++
> 2 files changed, 30 insertions(+)
>
> diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
> index 6439265..2560bf8 100644
> --- a/kernel-shark/src/KsMainWindow.cpp
> +++ b/kernel-shark/src/KsMainWindow.cpp
> @@ -76,6 +76,9 @@ KsMainWindow::KsMainWindow(QWidget *parent)
> _createMenus();
> _initCapture();
>
> + if (geteuid() == 0)
> + _rootWarning();
> +
> _splitter.addWidget(&_graph);
> _splitter.addWidget(&_view);
> setCentralWidget(&_splitter);
> @@ -1271,3 +1274,28 @@ void KsMainWindow::_deselectB()
> _mState.updateLabels();
> _graph.glPtr()->model()->update();
> }
> +
> +void KsMainWindow::_rootWarning()
> +{
> + QString cbFlag("noRootWorn");
Mike already pointed this out (Thanks Mike!)
> +
> + if (_settings.value(cbFlag).toBool())
> + return;
> +
> + QMessageBox warn;
> + warn.setText("KernelShark will have Root privileges.");
> + warn.setInformativeText("Continue on your one risk.");
Probably better to say:
"KernelShark is running with Root privileges."
"Continue at your own risk."
-- Steve
> + warn.setIcon(QMessageBox::Warning);
> + warn.setStandardButtons(QMessageBox::Close);
> +
> + QCheckBox cb("Don't show this message again.");
> +
> + auto lamCbChec = [&] (int state) {
> + if (state)
> + _settings.setValue(cbFlag, true);
> + };
> +
> + connect(&cb, &QCheckBox::stateChanged, lamCbChec);
> + warn.setCheckBox(&cb);
> + warn.exec();
> +}
> diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp
> index 62e66a0..4a7b8ab 100644
> --- a/kernel-shark/src/KsMainWindow.hpp
> +++ b/kernel-shark/src/KsMainWindow.hpp
> @@ -238,6 +238,8 @@ private:
>
> void _deselectB();
>
> + void _rootWarning();
> +
> void _updateFilterMenu();
>
> void _filterSyncCBoxUpdate(kshark_context *kshark_ctx);
next prev parent reply other threads:[~2019-08-09 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 8:06 [PATCH 0/3] Handle the case when KernelShark is started as Root Yordan Karadzhov (VMware)
2019-08-09 8:06 ` [PATCH 1/3] kernel-shark: Show warning message when running " Yordan Karadzhov (VMware)
[not found] ` <430194dd-0e96-bb3a-a2de-e4379dd540a1@gmail.com>
2019-08-09 12:13 ` Yordan Karadzhov (VMware)
2019-08-09 13:19 ` Steven Rostedt [this message]
2019-08-09 8:06 ` [PATCH 2/3] kernel-shark: Don't use pkexec " Yordan Karadzhov (VMware)
2019-08-09 13:33 ` Steven Rostedt
2019-08-09 8:06 ` [PATCH 3/3] kernel-shark: Use standart error message in KsMainWindow::_record() Yordan Karadzhov (VMware)
2019-08-09 13:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809091914.75f553b2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mike.auty@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).