From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com
Subject: Re: [PATCH 3/3] kernel-shark: Use standart error message in KsMainWindow::_record()
Date: Fri, 9 Aug 2019 09:35:51 -0400 [thread overview]
Message-ID: <20190809093551.73e7f06c@gandalf.local.home> (raw)
In-Reply-To: <20190809080623.7548-4-y.karadz@gmail.com>
On Fri, 9 Aug 2019 11:06:23 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
Typo in subject "standard".
Other than that, it looks good.
-- Steve
> The error message is printed using the method KsMainWindow::_error().
> The message itself remains unchanged. If we want to change the message,
> this can be done in another patch.
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
> kernel-shark/src/KsMainWindow.cpp | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
> index e9c6d54..b462ded 100644
> --- a/kernel-shark/src/KsMainWindow.cpp
> +++ b/kernel-shark/src/KsMainWindow.cpp
> @@ -890,7 +890,6 @@ void KsMainWindow::_record()
> #endif
>
> if (geteuid() && !canDoAsRoot) {
> - QErrorMessage *em = new QErrorMessage(this);
> QString message;
>
> message = "Record is currently not supported.";
> @@ -899,8 +898,7 @@ void KsMainWindow::_record()
> message += " ./cmake_clean.sh <br> cmake .. <br> make <br>";
> message += " sudo make install";
>
> - em->showMessage(message);
> - qCritical() << "ERROR: " << message;
> + _error(message, "recordCantStart", false, false);
> return;
> }
>
prev parent reply other threads:[~2019-08-09 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 8:06 [PATCH 0/3] Handle the case when KernelShark is started as Root Yordan Karadzhov (VMware)
2019-08-09 8:06 ` [PATCH 1/3] kernel-shark: Show warning message when running " Yordan Karadzhov (VMware)
[not found] ` <430194dd-0e96-bb3a-a2de-e4379dd540a1@gmail.com>
2019-08-09 12:13 ` Yordan Karadzhov (VMware)
2019-08-09 13:19 ` Steven Rostedt
2019-08-09 8:06 ` [PATCH 2/3] kernel-shark: Don't use pkexec " Yordan Karadzhov (VMware)
2019-08-09 13:33 ` Steven Rostedt
2019-08-09 8:06 ` [PATCH 3/3] kernel-shark: Use standart error message in KsMainWindow::_record() Yordan Karadzhov (VMware)
2019-08-09 13:35 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809093551.73e7f06c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mike.auty@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).