Re: trace-recorder.c patch

Re: trace-recorder.c patch

[Steven Rostedt]

Hi Kirill,

We try to follow the Linux kernel method of sending patches. You can
read that here:

  https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

If you only want to add this one fix and do not plan on sending other
fixes (thus you may not care about the formal process), at a minimum we
need you to add a:

 "Signed-off-by: Your Name <your-email>"

This is described in section 11 "Sign your work - the Developer’s
Certificate of Origin" of the above link.

Thanks!

-- Steve


On Thu, 15 Aug 2019 15:13:28 +0000
"Uhanov, Kirill" <kirill.uhanov@intel.com> wrote:

> Hi All.
> 
> Looks like some typo in lib/trace-cmd/trace-recorder.c
> 
> Could you apply patch?
> 
> diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c
> 
> index 0bd0657..650b259 100644
> 
> --- a/lib/trace-cmd/trace-recorder.c
> 
> +++ b/lib/trace-cmd/trace-recorder.c
> 
> @@ -244,7 +244,7 @@ tracecmd_create_buffer_recorder_maxkb(const char *file, int cpu, unsigned flags,
> 
>                              goto out;
> 
>                fd2 = open(file2, O_RDWR | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
> 
> -             if (fd < 0)
> 
> +             if (fd2 < 0)
> 
>                              goto err;
> 
>                recorder = tracecmd_create_buffer_recorder_fd2(fd, fd2, cpu, flags, buffer, maxkb);
> 
> Thanks, Kirill
> 
> --------------------------------------------------------------------
> Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,
> Russian Federation
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.