From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] kernel-shark: Use new tracefs library
Date: Wed, 8 Jan 2020 15:09:10 -0500 [thread overview]
Message-ID: <20200108150910.31167272@gandalf.local.home> (raw)
In-Reply-To: <20200106154058.60660-3-tz.stoyanov@gmail.com>
On Mon, 6 Jan 2020 17:40:55 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> diff --git a/kernel-shark/build/FindTraceCmd.cmake b/kernel-shark/build/FindTraceCmd.cmake
> index d3e145c..f27fafe 100644
> --- a/kernel-shark/build/FindTraceCmd.cmake
> +++ b/kernel-shark/build/FindTraceCmd.cmake
> @@ -6,6 +6,8 @@
> # TRACEEVENT_FOUND, If false, do not try to use traceevent.
> #
> # TRACECMD_INCLUDE_DIR, where to find trace-cmd header.
> +# TRACEFS_INCLUDE_DIR, where to find tracefs header.
> +# TRACEFS_LIBRARY, the tracefs library.
> # TRACECMD_LIBRARY, the trace-cmd library.
> # TRACECMD_FOUND, If false, do not try to use trace-cmd.
>
> @@ -31,12 +33,21 @@ find_path(TRACECMD_INCLUDE_DIR NAMES trace-cmd/trace-cmd.h
> PATHS $ENV{TRACE_CMD}/include/
> ${CMAKE_SOURCE_DIR}/../include/
> NO_DEFAULT_PATH)
> +find_path(TRACEFS_INCLUDE_DIR NAMES tracefs/tracefs.h
> + PATHS $ENV{TRACE_CMD}/include/
> + ${CMAKE_SOURCE_DIR}/../include/
> + NO_DEFAULT_PATH)
>
> find_library(TRACECMD_LIBRARY NAMES trace-cmd/libtracecmd.a
> PATHS $ENV{TRACE_CMD}/lib/
> ${CMAKE_SOURCE_DIR}/../lib/
> NO_DEFAULT_PATH)
>
> +find_library(TRACEFS_LIBRARY NAMES trace-cmd/libtracefs.a
I believe the above should be "tracefs/libtracefs.a" (I had to change
this to get it to compile).
-- Steve
> + PATHS $ENV{TRACE_CMD}/lib/
> + ${CMAKE_SOURCE_DIR}/../lib/
> + NO_DEFAULT_PATH)
> +
> find_library(TRACEEVENT_LIBRARY NAMES traceevent/libtraceevent.a
> PATHS $ENV{TRACE_CMD}/lib/
> ${CMAKE_SOURCE_DIR}/../lib/
next prev parent reply other threads:[~2020-01-08 20:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:40 [PATCH v2 0/5] tracefs library Tzvetomir Stoyanov (VMware)
2020-01-06 15:40 ` [PATCH v2 1/5] trace-cmd: Introduce libtracefs library Tzvetomir Stoyanov (VMware)
2020-01-06 15:40 ` [PATCH v2 2/5] kernel-shark: Use new tracefs library Tzvetomir Stoyanov (VMware)
2020-01-08 19:05 ` Steven Rostedt
2020-01-08 20:09 ` Steven Rostedt [this message]
2020-01-06 15:40 ` [PATCH v2 3/5] trace-cmd: New libtracefs APIs for ftrace instances Tzvetomir Stoyanov (VMware)
2020-01-08 19:37 ` Steven Rostedt
2020-01-09 13:29 ` Tzvetomir Stoyanov
2020-01-06 15:40 ` [PATCH v2 4/5] trace-cmd,kernel-shark: New libtracefs APIs for ftrace events and systems Tzvetomir Stoyanov (VMware)
2020-01-08 20:22 ` Steven Rostedt
2020-01-09 13:37 ` Tzvetomir Stoyanov
2020-01-08 21:09 ` Steven Rostedt
2020-01-09 14:14 ` Tzvetomir Stoyanov
2020-01-09 2:32 ` Steven Rostedt
2020-01-06 15:40 ` [PATCH v2 5/5] trace-cmd,kernel-shark: New libtracefs APIs for loading ftrace events Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108150910.31167272@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).