From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] kernel-shark: Simplify the search methods in class KsTraceViewer
Date: Mon, 4 May 2020 14:49:03 -0400 [thread overview]
Message-ID: <20200504144903.4f55d0df@gandalf.local.home> (raw)
In-Reply-To: <20200504174342.24615-2-y.karadz@gmail.com>
On Mon, 4 May 2020 20:43:40 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> +++ b/kernel-shark/src/KsTraceViewer.hpp
> @@ -132,8 +132,9 @@ private:
>
> size_t _searchItems();
>
> - void _searchItemsMapReduce(int column, const QString &searchText,
> - search_condition_func cond);
> + void _searchItemsST() {_proxyModel.search(&_searchFSM, &_matchList);}
> +
> + void _searchItemsMT();
>
> void _searchEditText(const QString &);
I'll pull this in as-is, but the above should definitely have comments
stating one is "Single threaded" and the other is "Multi threaded",
otherwise who would know what they mean?
-- Steve
next prev parent reply other threads:[~2020-05-04 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 17:43 [PATCH v2 0/3] kernel-shark: Have "stop" button for multi-threaded searches Yordan Karadzhov (VMware)
2020-05-04 17:43 ` [PATCH v2 1/3] kernel-shark: Simplify the search methods in class KsTraceViewer Yordan Karadzhov (VMware)
2020-05-04 18:49 ` Steven Rostedt [this message]
2020-05-04 17:43 ` [PATCH v2 2/3] kernel-shark: Change the mechanism of the multi-threaded search Yordan Karadzhov (VMware)
2020-05-04 17:43 ` [PATCH v2 3/3] kernel-shark: Make the "stop search" button always visible Yordan Karadzhov (VMware)
2020-05-04 18:58 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504144903.4f55d0df@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).