From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 0/8] Few libtraceeevnt fixes, suggested Namhyung Kim
Date: Tue, 14 Jul 2020 10:25:41 -0400 [thread overview]
Message-ID: <20200714102541.7dc27838@oasis.local.home> (raw)
In-Reply-To: <CAPpZLN6WVv3zUtcLgGAPoVJSOZtHDs+TOncXma-VS2TVRBL8BA@mail.gmail.com>
On Tue, 14 Jul 2020 15:12:10 +0300
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> On Tue, Jul 14, 2020 at 3:07 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > Hello,
> >
> > On Tue, Jul 14, 2020 at 7:30 PM Tzvetomir Stoyanov (VMware)
> > <tz.stoyanov@gmail.com> wrote:
> > >
> > > Fixes in libtraceeevnt, suggested by Namhyung Kim <namhyung@kernel.org>
> > >
> > > Tzvetomir Stoyanov (VMware) (8):
> > > trace-cmd: Document tep_load_plugins_hook()
> > > trace-cmd: Handle strdup() error in parse_option_name()
> > > trace-cmd: Fix typo in tep_plugin_add_option() description
> > > trace-cmd: Improve error handling of tep_plugin_add_option() API
> > > trace-cmd: Fixed broken indentation in parse_ip4_print_args()
> > > trace-cmd: Fixed type in PRINT_FMT_STING
> > > trace-cmd: Fixed description of tep_add_plugin_path() API
> > > trace-cmd: Handle possible strdup() error in tep_add_plugin_path() API
> >
> > Shouldn't the prefix be libtraceevent ? Other than that,
>
> I decided to address the comments in trace-cmd repo first, and after
> that to backport the patches to the kernel's libtraceevent. That's why
> the prefix is trace-cmd.
Actually, even in the trace-cmd repo, they should be labeled
libtraceveent, as they are specific for the libtraceevent portion of
trace-cmd.git. Otherwise everything in the repo would be trace-cmd: ;-)
I've tried to separate out different parts. Anything labeled trace-cmd:
should be for something unique to the trace-cmd executable. If
something is for libtracefs, it should be libtracefs: or tracefs:. If
it is for libtracevent, then that should be libtracevent: or traceevent:
-- Steve
next prev parent reply other threads:[~2020-07-14 14:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 10:30 [PATCH 0/8] Few libtraceeevnt fixes, suggested Namhyung Kim Tzvetomir Stoyanov (VMware)
2020-07-14 10:30 ` [PATCH 1/8] trace-cmd: Document tep_load_plugins_hook() Tzvetomir Stoyanov (VMware)
2020-07-14 14:28 ` Steven Rostedt
2020-07-14 15:22 ` Tzvetomir Stoyanov
2020-07-14 15:53 ` Steven Rostedt
2020-07-14 10:30 ` [PATCH 2/8] trace-cmd: Handle strdup() error in parse_option_name() Tzvetomir Stoyanov (VMware)
2020-07-14 10:30 ` [PATCH 3/8] trace-cmd: Fix typo in tep_plugin_add_option() description Tzvetomir Stoyanov (VMware)
2020-07-14 10:30 ` [PATCH 4/8] trace-cmd: Improve error handling of tep_plugin_add_option() API Tzvetomir Stoyanov (VMware)
2020-07-14 10:30 ` [PATCH 5/8] trace-cmd: Fixed broken indentation in parse_ip4_print_args() Tzvetomir Stoyanov (VMware)
2020-07-14 10:30 ` [PATCH 6/8] trace-cmd: Fixed type in PRINT_FMT_STING Tzvetomir Stoyanov (VMware)
2020-07-14 10:30 ` [PATCH 7/8] trace-cmd: Fixed description of tep_add_plugin_path() API Tzvetomir Stoyanov (VMware)
2020-07-14 10:30 ` [PATCH 8/8] trace-cmd: Handle possible strdup() error in " Tzvetomir Stoyanov (VMware)
2020-07-14 12:07 ` [PATCH 0/8] Few libtraceeevnt fixes, suggested Namhyung Kim Namhyung Kim
2020-07-14 12:12 ` Tzvetomir Stoyanov
2020-07-14 14:25 ` Steven Rostedt [this message]
2020-07-14 14:22 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714102541.7dc27838@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).