Re: [PATCH v4 06/20] kernel-shark: Add basic methods for Data streams

From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v4 06/20] kernel-shark: Add basic methods for Data streams
Date: Thu, 19 Nov 2020 11:38:55 -0500	[thread overview]
Message-ID: <20201119113855.6d0df6a6@gandalf.local.home> (raw)
In-Reply-To: <3ea5483a-9cb7-cbf0-e3ab-0b354228a387@gmail.com>

On Thu, 19 Nov 2020 18:01:30 +0200
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> Hi Steven,
> 
> I have no strong preference about having or not having this extra space.
> For me, having the space makes the C-like casting look more similar to a 
> new declaration on contrary to the C++-like casting that will be 
> something like this
> 
> 	unsigned long i(340);
> 	char c = char(i);
> 
> and looks more like a constructor call.
> Of course C++ will not let you cast number to pointer this way.

As long as you are consistent, but I'm just letting you know the
appropriate style for the Linux kernel, which is no space:

	type x = (type)y;

But again, this is really up to you, but just be aware if you submit to the
kernel, the above is the expected style.

-- Steve