Re: [PATCH v4 14/20] kernel-shark: Provide merging of multiple data streams

From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v4 14/20] kernel-shark: Provide merging of multiple data streams
Date: Thu, 19 Nov 2020 19:48:29 +0200	[thread overview]
Message-ID: <5ed5fd96-4c8b-7fe8-56d4-47f09df9dce5@gmail.com> (raw)
In-Reply-To: <20201119114337.01d5657a@gandalf.local.home>

On 19.11.20 г. 18:43 ч., Steven Rostedt wrote:
> On Thu, 19 Nov 2020 18:14:36 +0200
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> 
>>>    
>>>> +
>>>> +	if (sd < 0) {
>>>> +		kshark_free(kshark_ctx);
>>>> +		return 1;
>>>> +	}
>>>> +
>>>> +	/* Initialize data streams for all buffers in this file. */
>>>> +	kshark_tep_init_all_buffers(kshark_ctx, sd);
>>
>> And here is the place where it opens in separate streams the other
>> buffers that are in the same file.
>>
> 
> Ah so it requires that the file have buffers recorded. OK, I'll try it out.

Hi Steven,
If you want to open a second file, just replace 
kshark_tep_init_all_buffers() with another call of kshark_open().

I will wait to see if you will find more problems before sending v5.
Thanks a lot!
Y.

> 
> -- Steve
> 
> 