linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] libtracefs: Library building fixes
@ 2020-12-03 19:06 Steven Rostedt
  2020-12-03 19:06 ` [PATCH 1/2] libtracefs: Remove useless LIBS = -ldl in Makefile Steven Rostedt
  2020-12-03 19:06 ` [PATCH 2/2] libtracefs: Add $(LIBS) to building of shared object library Steven Rostedt
  0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2020-12-03 19:06 UTC (permalink / raw)
  To: linux-trace-devel


Steven Rostedt (VMware) (2):
      libtracefs: Remove useless LIBS = -ldl in Makefile
      libtracefs: Add $(LIBS) to building of shared object library

----
 Makefile         | 2 --
 scripts/utils.mk | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] libtracefs: Remove useless LIBS = -ldl in Makefile
  2020-12-03 19:06 [PATCH 0/2] libtracefs: Library building fixes Steven Rostedt
@ 2020-12-03 19:06 ` Steven Rostedt
  2020-12-03 19:06 ` [PATCH 2/2] libtracefs: Add $(LIBS) to building of shared object library Steven Rostedt
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2020-12-03 19:06 UTC (permalink / raw)
  To: linux-trace-devel

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

The Makefile includes a LIBS = -ldl, which was copied over from trace-cmd
and is not needed for libtracefs as there's no dynamic linking going on.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Makefile b/Makefile
index c5b13ca869b7..ff95748c0684 100644
--- a/Makefile
+++ b/Makefile
@@ -124,8 +124,6 @@ bdir		:= $(obj)/lib/tracefs
 
 export prefix bindir src obj
 
-LIBS = -ldl
-
 LIBTRACEFS_DIR = $(obj)/lib/tracefs
 LIBTRACEFS_STATIC = $(LIBTRACEFS_DIR)/libtracefs.a
 LIBTRACEFS_SHARED = $(LIBTRACEFS_DIR)/libtracefs.so.$(TRACEFS_VERSION)
-- 
2.28.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] libtracefs: Add $(LIBS) to building of shared object library
  2020-12-03 19:06 [PATCH 0/2] libtracefs: Library building fixes Steven Rostedt
  2020-12-03 19:06 ` [PATCH 1/2] libtracefs: Remove useless LIBS = -ldl in Makefile Steven Rostedt
@ 2020-12-03 19:06 ` Steven Rostedt
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2020-12-03 19:06 UTC (permalink / raw)
  To: linux-trace-devel

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

libtracefs.so relies on libtraceevent.so, but it an application were to
include libtracefs.so, it should not be required to include libtraceevent.so
if that application is not using it. Add the libtraceevent library to the
build of libtracefs.so so that what libtracefs.so uses is included in that
code.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 scripts/utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/utils.mk b/scripts/utils.mk
index d1d5135063fc..1ee283fe4393 100644
--- a/scripts/utils.mk
+++ b/scripts/utils.mk
@@ -61,7 +61,7 @@ do_build_static_lib =				\
 
 do_compile_shared_library =			\
 	($(print_shared_lib_compile)		\
-	$(CC) --shared $^ -Wl,-soname,$(@F) -o $@)
+	$(CC) --shared $^ -Wl,-soname,$(@F) -o $@ $(LIBS))
 
 do_compile_plugin_obj =				\
 	($(print_plugin_obj_compile)		\
-- 
2.28.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-03 19:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 19:06 [PATCH 0/2] libtracefs: Library building fixes Steven Rostedt
2020-12-03 19:06 ` [PATCH 1/2] libtracefs: Remove useless LIBS = -ldl in Makefile Steven Rostedt
2020-12-03 19:06 ` [PATCH 2/2] libtracefs: Add $(LIBS) to building of shared object library Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).