linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] libtracefs: Remove gui references and do not fail make clean
@ 2020-12-16 21:57 Steven Rostedt
  2020-12-16 21:57 ` [PATCH 1/2] libtracefs: Remove Makfefile targets that reference "gui" Steven Rostedt
  2020-12-16 21:57 ` [PATCH 2/2] libtracefs: Do not fail make on clean target Steven Rostedt
  0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2020-12-16 21:57 UTC (permalink / raw)
  To: linux-trace-devel


Steven Rostedt (VMware) (2):
      libtracefs: Remove Makfefile targets that reference "gui"
      libtracefs: Do not fail make on clean target

----
 Makefile | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] libtracefs: Remove Makfefile targets that reference "gui"
  2020-12-16 21:57 [PATCH 0/2] libtracefs: Remove gui references and do not fail make clean Steven Rostedt
@ 2020-12-16 21:57 ` Steven Rostedt
  2020-12-16 21:57 ` [PATCH 2/2] libtracefs: Do not fail make on clean target Steven Rostedt
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2020-12-16 21:57 UTC (permalink / raw)
  To: linux-trace-devel

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

libtracefs was taken from trace-cmd which held kernelshark at the time, and
to build kernelshark, "make gui" and other targets were used. These were
mistakenly copied over to the Makefile to build the stand alone libtracefs.
Remove them.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 Makefile | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/Makefile b/Makefile
index 47ac4f5e8c8c..daaf347966b9 100644
--- a/Makefile
+++ b/Makefile
@@ -253,19 +253,12 @@ install_pkgconfig: $(PKG_CONFIG_FILE)
 
 doc:
 	$(MAKE) -C $(src)/Documentation all
-doc_gui:
-	$(MAKE) -C $(kshark-dir)/Documentation all
-
 
 doc_clean:
 	$(MAKE) -C $(src)/Documentation clean
-doc_gui_clean:
-	$(MAKE) -C $(kshark-dir)/Documentation clean
 
 install_doc:
 	$(MAKE) -C $(src)/Documentation install
-install_doc_gui:
-	$(MAKE) -C $(kshark-dir)/Documentation install
 
 define build_uninstall_script
 	$(Q)mkdir $(BUILD_OUTPUT)/tmp_build
-- 
2.29.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] libtracefs: Do not fail make on clean target
  2020-12-16 21:57 [PATCH 0/2] libtracefs: Remove gui references and do not fail make clean Steven Rostedt
  2020-12-16 21:57 ` [PATCH 1/2] libtracefs: Remove Makfefile targets that reference "gui" Steven Rostedt
@ 2020-12-16 21:57 ` Steven Rostedt
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2020-12-16 21:57 UTC (permalink / raw)
  To: linux-trace-devel

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

"make clean" should not fail because libtraceevent is not installed on the
system.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index daaf347966b9..e32bcaee3cba 100644
--- a/Makefile
+++ b/Makefile
@@ -65,8 +65,10 @@ pkgconfig_dir ?= $(word 1,$(shell $(PKG_CONFIG) 		\
 LIBTRACEEVENT_INCLUDES = $(shell $(PKG_CONFIG) --cflags libtraceevent)
 LIBTRACEEVENT_LIBS = $(shell $(PKG_CONFIG) --libs libtraceevent)
 
-ifeq ("$(LIBTRACEEVENT_INCLUDES)","")
-$(error libtraceevent.so not installed)
+ifneq ($(MAKECMDGOALS),clean)
+ ifeq ("$(LIBTRACEEVENT_INCLUDES)","")
+   $(error libtraceevent.so not installed)
+ endif
 endif
 
 etcdir ?= /etc
-- 
2.29.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-16 21:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 21:57 [PATCH 0/2] libtracefs: Remove gui references and do not fail make clean Steven Rostedt
2020-12-16 21:57 ` [PATCH 1/2] libtracefs: Remove Makfefile targets that reference "gui" Steven Rostedt
2020-12-16 21:57 ` [PATCH 2/2] libtracefs: Do not fail make on clean target Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).