* [PATCH] trace-cmd: Fix create_recorder() path assignment
@ 2021-02-09 0:36 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2021-02-09 0:36 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The assignment of path was suppose to copy the dir variable that is returned
from tracefs_tracing_dir(), but instead the path copied itself.
This broke the communication between host and guest as well as networking.
Fixes: b8498696e0 ("trace-cmd: Use tracefs_tracing_dir() instead of tracefs_find_tracing_dir()")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
tracecmd/trace-record.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index a1c4e919..b05eef35 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -3341,7 +3341,7 @@ static int create_recorder(struct buffer_instance *instance, int cpu,
const char *dir = tracefs_tracing_dir();
if (dir)
- path = strdup(path);
+ path = strdup(dir);
}
if (!path)
die("can't get the tracing directory");
--
2.25.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-09 0:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 0:36 [PATCH] trace-cmd: Fix create_recorder() path assignment Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).