From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 15/23] trace-cmd: Set order and priorities when applying timestamp corrections
Date: Wed, 24 Mar 2021 14:51:44 -0400 [thread overview]
Message-ID: <20210324145144.067efa87@gandalf.local.home> (raw)
In-Reply-To: <20210324130418.436206-16-tz.stoyanov@gmail.com>
On Wed, 24 Mar 2021 15:04:10 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> @@ -1296,15 +1287,23 @@ static unsigned long long timestamp_correct(unsigned long long ts,
> static unsigned long long timestamp_calc(unsigned long long ts,
> struct tracecmd_input *handle)
> {
> - ts = timestamp_correct(ts, handle);
> + /* Guest trace file, sync with host timestamps */
> + if (handle->host.sync_enable)
> + ts = timestamp_host_sync(ts, handle);
>
> - if (handle->ts2secs)
> + if (handle->ts2secs) {
> + /* user specified clock frequency */
> ts *= handle->ts2secs;
> - else if (handle->tsc_calc.mult) {
> + } else if (handle->tsc_calc.mult) {
> + /* auto calculated TSC clock frequency */
> ts -= handle->tsc_calc.offset;
> ts = mul_u64_u32_shr(ts, handle->tsc_calc.mult, handle->tsc_calc.shift);
> }
>
> + /* User specified time offset with --ts-offset or --date options */
> + if (handle->ts_offset)
> + ts += handle->ts_offset;
> +
> return ts;
> }
Now that I'm playing with this, I find I want to see what the result is
without the tsc_calc.offset, but can't do it. I'm thinking that the
--ts-offset should modify that instead:
bool ts_offset_set = false;
[..]
} else if (handel->tsc_calc.mult) {
ts_offset_set = true;
if (handle->ts_offset)
ts += handle->ts_offset;
else
ts -= handle->tsc_calc.offset;
[..]
}
if (handle->ts_offset && !ts_offset_set)
ts += handle->ts_offset;
Or should we add another option to modify the ts_calc.offset?
Thoughts?
-- Steve
next prev parent reply other threads:[~2021-03-24 18:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 13:03 [PATCH v3 00/23] TSC trace clock to nanosecond conversion Tzvetomir Stoyanov (VMware)
2021-03-24 13:03 ` [PATCH v3 01/23] trace-cmd: Add initial perf interface in trace-cmd library Tzvetomir Stoyanov (VMware)
2021-03-24 13:03 ` [PATCH v3 02/23] trace-cmd: Extend trace-cmd dump subcommand to display the clock Tzvetomir Stoyanov (VMware)
2021-03-24 17:57 ` Steven Rostedt
2021-03-24 18:02 ` Steven Rostedt
2021-03-24 13:03 ` [PATCH v3 03/23] trace-cmd: Save only the selected clock in the trace.dat file Tzvetomir Stoyanov (VMware)
2021-03-24 13:03 ` [PATCH v3 04/23] trace-cmd: Internal refactoring, move logic for local tep handler in its own function Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 05/23] trace-cmd: Add new local function to check if a trace clock is supported Tzvetomir Stoyanov (VMware)
2021-03-24 17:49 ` Steven Rostedt
2021-03-24 13:04 ` [PATCH v3 06/23] trace-cmd: Add new trace-cmd clock tsc2nsec Tzvetomir Stoyanov (VMware)
2021-03-24 15:05 ` Steven Rostedt
2021-03-24 15:20 ` Steven Rostedt
2021-03-24 15:38 ` Tzvetomir Stoyanov
2021-03-24 16:22 ` Steven Rostedt
2021-03-24 16:56 ` Tzvetomir Stoyanov
2021-03-24 20:55 ` Steven Rostedt
2021-03-24 18:32 ` Steven Rostedt
2021-03-24 18:33 ` Steven Rostedt
2021-03-24 13:04 ` [PATCH v3 07/23] trace-cmd: Define a new option for tsc2nsec conversion Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 08/23] trace-cmd: Save information for tsc to nanoseconds conversion in trace file Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 09/23] trace-cmd: Read information for tsc to nanoseconds conversion from " Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 10/23] trace-cmd: Save tsc2nsec clock in trace.dat file Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 11/23] trace-cmd: Append new options into guest trace file at the end of the tracing session Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 12/23] trace-cmd: Remove unneeded multiply in events timestamp reading Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 13/23] trace-cmd: Perform all timestamp corrections in a single function Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 14/23] trace-cmd: Convert tsc timestamps to nanosecods when reading trace data from a file Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 15/23] trace-cmd: Set order and priorities when applying timestamp corrections Tzvetomir Stoyanov (VMware)
2021-03-24 18:51 ` Steven Rostedt [this message]
2021-03-25 6:29 ` Tzvetomir Stoyanov
2021-03-24 13:04 ` [PATCH v3 16/23] trace-cmd: Add a new flag to disable any " Tzvetomir Stoyanov (VMware)
2021-03-24 14:24 ` Steven Rostedt
2021-03-24 15:20 ` Steven Rostedt
2021-03-24 13:04 ` [PATCH v3 17/23] trace-cmd: Change "--nodate" option to affect "--date" option only Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 18/23] trace-cmd: Add new parameter "--raw-ts" to "trace-cmd report" command Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 19/23] trace-cmd: Print times in TimeShift options as unsigned in trace-cmd dump Tzvetomir Stoyanov (VMware)
2021-03-24 15:33 ` Steven Rostedt
2021-03-24 13:04 ` [PATCH v3 20/23] trace-cmd: Use tsc clock for host-guest tracing, if available Tzvetomir Stoyanov (VMware)
2021-03-24 13:04 ` [PATCH v3 21/23] trace-cmd: Get current clock for host-guest tracing session Tzvetomir Stoyanov (VMware)
2021-03-24 21:15 ` Steven Rostedt
2021-03-25 5:13 ` Tzvetomir Stoyanov
2021-03-25 13:41 ` Steven Rostedt
2021-03-24 13:04 ` [PATCH v3 22/23] trace-cmd: Save the trace clocks in TRACECLOCK option Tzvetomir Stoyanov (VMware)
2021-03-24 21:24 ` Steven Rostedt
2021-03-25 5:35 ` Tzvetomir Stoyanov
2021-03-24 13:04 ` [PATCH v3 23/23] trace-cmd: Read at least 8 bytes trace-id option Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324145144.067efa87@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).