From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 6/6] trace-cmd record: Add new parameter --file-version
Date: Wed, 28 Apr 2021 21:26:18 -0400 [thread overview]
Message-ID: <20210428212618.41262613@oasis.local.home> (raw)
In-Reply-To: <20210422071718.483383-7-tz.stoyanov@gmail.com>
On Thu, 22 Apr 2021 10:17:18 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> Added a new optional parameter to "trace-cmd record", can be used to
> select the desired file version of the trace output file.
>
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
Even with this last patch, I still get:
trace-input.c: In function ‘tracecmd_get_file_version’:
trace-input.c:4033:15: error: ‘struct tracecmd_input’ has no member named ‘file_version’
4033 | return handle->file_version;
| ^~
trace-input.c:4034:1: warning: control reaches end of non-void function [-Wreturn-type]
4034 | }
So you must have added a change without somehow committing it :-/
-- Steve
next prev parent reply other threads:[~2021-04-29 1:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:17 [PATCH 0/6] Bump trace file version Tzvetomir Stoyanov (VMware)
2021-04-22 7:17 ` [PATCH 1/6] trace-cmd library: Bump the trace file version to 7 Tzvetomir Stoyanov (VMware)
2021-04-29 1:19 ` Steven Rostedt
2021-04-29 3:43 ` Tzvetomir Stoyanov
2021-04-29 13:16 ` Steven Rostedt
2021-04-22 7:17 ` [PATCH 2/6] trace-cmd library: Add new API to get file version of input handler Tzvetomir Stoyanov (VMware)
2021-04-29 1:20 ` Steven Rostedt
2021-04-22 7:17 ` [PATCH 3/6] trace-cmd library: Select the file version when writing trace file Tzvetomir Stoyanov (VMware)
2021-04-22 7:17 ` [PATCH 4/6] trace-cmd library: Remove unused private APIs for creating trace files Tzvetomir Stoyanov (VMware)
2021-04-29 1:22 ` Steven Rostedt
2021-04-22 7:17 ` [PATCH 5/6] trace-cmd library: Extend the create file APIs to support different file version Tzvetomir Stoyanov (VMware)
2021-04-22 7:17 ` [PATCH 6/6] trace-cmd record: Add new parameter --file-version Tzvetomir Stoyanov (VMware)
2021-04-29 1:26 ` Steven Rostedt [this message]
2021-04-29 3:34 ` Tzvetomir Stoyanov
2021-04-29 12:55 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428212618.41262613@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).