From: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 1/6] trace-cmd library: Bump the trace file version to 7
Date: Thu, 29 Apr 2021 06:43:54 +0300 [thread overview]
Message-ID: <CAPpZLN5g3ySyo-sWpB9nyumRzQCLngzbwHeG6b1Z8YVW1augCg@mail.gmail.com> (raw)
In-Reply-To: <20210428211920.001a66c8@oasis.local.home>
On Thu, Apr 29, 2021 at 4:19 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 22 Apr 2021 10:17:13 +0300
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
>
> > Adding a compression of the trace.dat file will change its structure.
> > These changes are not backward compatible, the old trace-cmd binaries
> > will not be able to read compressed trace files. Bumping the version to
> > 7 will prevent old trace-cmd to read such files.
>
> But this series doesn't add anything to the file that breaks the
> version. The version should be updated with the patch that breaks the
> backward compatibility. of the file, not before.
>
I need the new version before the compression changes, because there
is logic which relies on the new version. There is a check whether to
read / write compression data based on the new file version. I was
wondering if to put all changes into a single patchset, version +
compression. Decided to split in two, although there is no sense to
bump the version without adding a compression.
> -- Steve
[...]
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
next prev parent reply other threads:[~2021-04-29 3:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:17 [PATCH 0/6] Bump trace file version Tzvetomir Stoyanov (VMware)
2021-04-22 7:17 ` [PATCH 1/6] trace-cmd library: Bump the trace file version to 7 Tzvetomir Stoyanov (VMware)
2021-04-29 1:19 ` Steven Rostedt
2021-04-29 3:43 ` Tzvetomir Stoyanov [this message]
2021-04-29 13:16 ` Steven Rostedt
2021-04-22 7:17 ` [PATCH 2/6] trace-cmd library: Add new API to get file version of input handler Tzvetomir Stoyanov (VMware)
2021-04-29 1:20 ` Steven Rostedt
2021-04-22 7:17 ` [PATCH 3/6] trace-cmd library: Select the file version when writing trace file Tzvetomir Stoyanov (VMware)
2021-04-22 7:17 ` [PATCH 4/6] trace-cmd library: Remove unused private APIs for creating trace files Tzvetomir Stoyanov (VMware)
2021-04-29 1:22 ` Steven Rostedt
2021-04-22 7:17 ` [PATCH 5/6] trace-cmd library: Extend the create file APIs to support different file version Tzvetomir Stoyanov (VMware)
2021-04-22 7:17 ` [PATCH 6/6] trace-cmd record: Add new parameter --file-version Tzvetomir Stoyanov (VMware)
2021-04-29 1:26 ` Steven Rostedt
2021-04-29 3:34 ` Tzvetomir Stoyanov
2021-04-29 12:55 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPpZLN5g3ySyo-sWpB9nyumRzQCLngzbwHeG6b1Z8YVW1augCg@mail.gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).