From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 2/4] libtraceevent: Add logs with severity info
Date: Wed, 5 May 2021 05:55:17 -0400 [thread overview]
Message-ID: <20210505055517.70b552ee@oasis.local.home> (raw)
In-Reply-To: <CAPpZLN4opBm_OQm2HYH73PmpBOmV9VMaV1vt+Wx_EzjOOAPWcw@mail.gmail.com>
On Wed, 5 May 2021 07:45:44 +0300
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> On Tue, May 4, 2021 at 11:24 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Wed, 28 Apr 2021 10:29:59 +0300
> > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> >
> > And let the tep_vprint() decide to print it or not.
>
> The tep_vprint() is used also by libtacecmd and libtracefs for
> printing logs. Each library has its own log_level local variable,
> that's why I check the log level in the library specific log
> functions.
But tep_vprint() looks like this:
int __weak tep_vprint(const char *name, enum tep_loglevel level, const char *fmt, va_list ap)
{
int ret = errno;
if (errno && level <= TEP_LOG_WARNING)
perror(name);
fprintf(stderr, " ");
vfprintf(stderr, fmt, ap);
fprintf(stderr, "\n");
return ret;
}
That check of the log level is confusing. Just remove it. In fact, we
should add a boolean on whether to print the errno message or not.
Like this:
int __weak tep_vprint(const char *name, bool print_errno, const char *fmt, va_list ap)
{
int ret = errno;
if (errno && print_errno)
perror(name);
fprintf(stderr, " ");
vfprintf(stderr, fmt, ap);
fprintf(stderr, "\n");
return ret;
}
That would make a lot more sense, and let the callers of it decide to
print it or not, and not have the internal level of libtraceevent
decide.
-- Steve
next prev parent reply other threads:[~2021-05-05 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:29 [PATCH 0/4] Add severity to library logs Tzvetomir Stoyanov (VMware)
2021-04-28 7:29 ` [PATCH 1/4] libtraceevent: Add log levels Tzvetomir Stoyanov (VMware)
2021-04-28 7:29 ` [PATCH 2/4] libtraceevent: Add logs with severity info Tzvetomir Stoyanov (VMware)
2021-05-04 20:00 ` Steven Rostedt
2021-05-04 20:34 ` Steven Rostedt
2021-05-04 20:24 ` Steven Rostedt
2021-05-05 4:45 ` Tzvetomir Stoyanov
2021-05-05 9:55 ` Steven Rostedt [this message]
2021-04-28 7:30 ` [PATCH 3/4] libtraceevent: Rename tep_vwarning() to tep_vprint() Tzvetomir Stoyanov (VMware)
2021-05-04 20:22 ` Steven Rostedt
2021-04-28 7:30 ` [PATCH 4/4] libtraceevent: Document new log functionality Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505055517.70b552ee@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).