Re: [PATCH] libtraceevent: Fix bug in tep_print_event()

From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtraceevent: Fix bug in tep_print_event()
Date: Wed, 30 Jun 2021 11:06:35 -0400	[thread overview]
Message-ID: <20210630110635.57411548@oasis.local.home> (raw)
In-Reply-To: <20210630141913.20675-1-y.karadz@gmail.com>

On Wed, 30 Jun 2021 17:19:13 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> {
>  	struct print_event_type type;
> -	char *format = strdup(fmt);
> -	char *current = format;
> -	char *str = format;
> +	char *format, *current, *str;

Nit, but please keep the above each on a separate line.

	char *current;
	char *format;
	char *str;

I try to avoid having pointers on a single line, it's just easier to
manage when they are separate.

Thanks!

-- Steve

>  	int offset;
>  	va_list args;
>  	struct tep_event *event;
>  
> +	event = tep_find_event_by_record(tep, record);
> +	if (!event) {
> +		trace_seq_printf(s, "[UNKNOWN EVENT]");
> +		return;
> +	}
> +
> +	str = current = format = strdup(fmt);
>  	if (!format)
>  		return;