From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH] libtraceevent: Fix bug in tep_print_event()
Date: Wed, 30 Jun 2021 17:19:13 +0300 [thread overview]
Message-ID: <20210630141913.20675-1-y.karadz@gmail.com> (raw)
We must handle the case when the "tep_event" object is not found.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
src/event-parse.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/event-parse.c b/src/event-parse.c
index de28b3b..d3f1bba 100644
--- a/src/event-parse.c
+++ b/src/event-parse.c
@@ -6418,17 +6418,21 @@ void tep_print_event(struct tep_handle *tep, struct trace_seq *s,
struct tep_record *record, const char *fmt, ...)
{
struct print_event_type type;
- char *format = strdup(fmt);
- char *current = format;
- char *str = format;
+ char *format, *current, *str;
int offset;
va_list args;
struct tep_event *event;
+ event = tep_find_event_by_record(tep, record);
+ if (!event) {
+ trace_seq_printf(s, "[UNKNOWN EVENT]");
+ return;
+ }
+
+ str = current = format = strdup(fmt);
if (!format)
return;
- event = tep_find_event_by_record(tep, record);
va_start(args, fmt);
while (*current) {
current = strchr(str, '%');
--
2.27.0
next reply other threads:[~2021-06-30 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 14:19 Yordan Karadzhov (VMware) [this message]
2021-06-30 15:06 ` [PATCH] libtraceevent: Fix bug in tep_print_event() Steven Rostedt
2021-06-30 18:37 ` Yordan Karadzhov (VMware)
2021-06-30 18:50 ` Steven Rostedt
2021-06-30 19:38 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630141913.20675-1-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).