From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Remove leftover regcomp() in event_enable_disable()
Date: Fri, 2 Jul 2021 07:43:33 -0400 [thread overview]
Message-ID: <20210702074333.7e3f0529@rorschach.local.home> (raw)
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
When adding a helper function to perform the regex compiling
(make_regex()), one place left the open coded compiling but still added
the wrapper function.
Link: https://lore.kernel.org/linux-trace-devel/48ad3a02-f4bf-1579-df6a-f4dc206a7e4e@gmail.com/
Reported-by: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Fixes: de8592c0ef ("libtracefs: Fix tracefs_event_enable/disable() to not have open regex")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
src/tracefs-events.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/tracefs-events.c b/src/tracefs-events.c
index b6d3136..568bfe6 100644
--- a/src/tracefs-events.c
+++ b/src/tracefs-events.c
@@ -868,7 +868,6 @@ static int event_enable_disable(struct tracefs_instance *instance,
if (system) {
ret = make_regex(&system_re, system);
- ret = regcomp(&system_re, system, REG_ICASE|REG_NOSUB);
if (ret < 0)
goto out_free;
}
--
2.31.1
reply other threads:[~2021-07-02 11:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702074333.7e3f0529@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).