[PATCH] libtracefs: Fix bug in tracefs_instances()

[PATCH] libtracefs: Fix bug in tracefs_instances()

[Yordan Karadzhov (VMware)]

The empty string is now made of two elements, because of the hidden
first element that stores its size.

Fixes: 056a177 (libtracefs: Restructure how string lists work)
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
 src/tracefs-instance.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c
index 11fb580..d601db2 100644
--- a/src/tracefs-instance.c
+++ b/src/tracefs-instance.c
@@ -694,7 +694,7 @@ char **tracefs_instances(const char *regex)
 	} else {
 		/* No matches should produce an empty list */
 		if (!list.list)
-			list.list = calloc(1, sizeof(*list.list));
+			list.list = trace_list_create_empty();
 	}
 	return list.list;
 }
-- 
2.27.0

Re: [PATCH] libtracefs: Fix bug in tracefs_instances()

[Steven Rostedt]

On Wed,  7 Jul 2021 16:05:23 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> The empty string is now made of two elements, because of the hidden
> first element that stores its size.
> 
> Fixes: 056a177 (libtracefs: Restructure how string lists work)
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
>  src/tracefs-instance.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c
> index 11fb580..d601db2 100644
> --- a/src/tracefs-instance.c
> +++ b/src/tracefs-instance.c
> @@ -694,7 +694,7 @@ char **tracefs_instances(const char *regex)
>  	} else {
>  		/* No matches should produce an empty list */
>  		if (!list.list)
> -			list.list = calloc(1, sizeof(*list.list));
> +			list.list = trace_list_create_empty();
>  	}
>  	return list.list;
>  }

Thanks! I guess I missed one :-p

-- Steve