linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philippe Duplessis-Guindon <pduplessis@efficios.com>
To: linux-trace-devel@vger.kernel.org
Subject: Duplicate fields in event format of `regcache_sync `
Date: Fri, 20 Nov 2020 12:50:33 -0500	[thread overview]
Message-ID: <53fe53a9-0589-2bc6-1883-6f696fdee9ac@efficios.com> (raw)

Hi,

I am doing an ftrace plugin for Babeltrace 2 [1], and while I was 
parsing the event fields I had an error saying that `regcache_sync` has 
2 fields named `type`. The problem seems to come from the 
drivers/base/regmap/trace.h file [2]. This is the patch where this was 
added: [3]. The `int field` type is not assigned, so I was wondering if 
it is normal that the field is there.

This is the format of this event:

$ sudo cat /sys/kernel/debug/tracing/events/regmap/regcache_sync/format
name: regcache_sync
ID: 1216
format:
   field:unsigned short common_type;    offset:0;    size:2;    signed:0;
   field:unsigned char common_flags;    offset:2;    size:1;    signed:0;
   field:unsigned char common_preempt_count; offset:3; size:1;signed:0;
   field:int common_pid;    offset:4;    size:4;    signed:1;

   field:__data_loc char[] name;    offset:8;    size:4;    signed:1;
   field:__data_loc char[] status;    offset:12;    size:4;    signed:1;
   field:__data_loc char[] type;    offset:16;    size:4;    signed:1;
   field:int type;    offset:20;    size:4;    signed:1;

   print fmt: "%s type=%s status=%s", __get_str(name), __get_str(type), 
__get_str(status)

Thank you,

Philippe


[1] https://babeltrace.org/

[2] 
https://github.com/torvalds/linux/blob/master/drivers/base/regmap/trace.h#L129

[3] 
https://github.com/torvalds/linux/commit/593600890110c02eb471cf844649dee213870416

             reply	other threads:[~2020-11-20 17:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 17:50 Philippe Duplessis-Guindon [this message]
2020-11-20 18:47 ` Duplicate fields in event format of `regcache_sync ` Steven Rostedt
2020-11-20 19:03   ` Philippe Duplessis-Guindon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53fe53a9-0589-2bc6-1883-6f696fdee9ac@efficios.com \
    --to=pduplessis@efficios.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).