* [PATCH] KernelShark: Add guest's stream ID to the combobox item.
@ 2020-09-02 16:11 Tzvetomir Stoyanov (VMware)
2020-09-03 13:53 ` Yordan Karadzhov (VMware)
0 siblings, 1 reply; 2+ messages in thread
From: Tzvetomir Stoyanov (VMware) @ 2020-09-02 16:11 UTC (permalink / raw)
To: rostedt, y.karadz; +Cc: linux-trace-devel
From: Tzvetomir (VMware) Stoyanov <tz.stoyanov@gmail.com>
When a new stream is added to the list of guest streams in the ComboBox
plugin, attach the stream ID to the entry as well. Later, when the
stream is selected from the list, this ID is used to get information of
the stream.
Signed-off-by: Tzvetomir (VMware) Stoyanov <tz.stoyanov@gmail.com>
---
src/plugins/KVMCombo.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/plugins/KVMCombo.cpp b/src/plugins/KVMCombo.cpp
index 4ca33d4..bc3c6b0 100644
--- a/src/plugins/KVMCombo.cpp
+++ b/src/plugins/KVMCombo.cpp
@@ -269,7 +269,7 @@ void KsComboPlotDialog::update()
continue;
streamName = KsUtils::streamDescription(kshark_ctx->stream[sd]);
- _guestStreamComboBox.addItem(streamName);
+ _guestStreamComboBox.addItem(streamName, sd);
color << colTable[sd];
_guestStreamComboBox.setItemData(i, QBrush(color),
Qt::BackgroundRole);
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KernelShark: Add guest's stream ID to the combobox item.
2020-09-02 16:11 [PATCH] KernelShark: Add guest's stream ID to the combobox item Tzvetomir Stoyanov (VMware)
@ 2020-09-03 13:53 ` Yordan Karadzhov (VMware)
0 siblings, 0 replies; 2+ messages in thread
From: Yordan Karadzhov (VMware) @ 2020-09-03 13:53 UTC (permalink / raw)
To: Tzvetomir Stoyanov (VMware), rostedt; +Cc: linux-trace-devel
On 2.09.20 г. 19:11 ч., Tzvetomir Stoyanov (VMware) wrote:
> From: Tzvetomir (VMware) Stoyanov <tz.stoyanov@gmail.com>
>
> When a new stream is added to the list of guest streams in the ComboBox
> plugin, attach the stream ID to the entry as well. Later, when the
> stream is selected from the list, this ID is used to get information of
> the stream.
>
> Signed-off-by: Tzvetomir (VMware) Stoyanov <tz.stoyanov@gmail.com>
> ---
> src/plugins/KVMCombo.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/plugins/KVMCombo.cpp b/src/plugins/KVMCombo.cpp
> index 4ca33d4..bc3c6b0 100644
> --- a/src/plugins/KVMCombo.cpp
> +++ b/src/plugins/KVMCombo.cpp
> @@ -269,7 +269,7 @@ void KsComboPlotDialog::update()
> continue;
>
> streamName = KsUtils::streamDescription(kshark_ctx->stream[sd]);
> - _guestStreamComboBox.addItem(streamName);
> + _guestStreamComboBox.addItem(streamName, sd);
> color << colTable[sd];
> _guestStreamComboBox.setItemData(i, QBrush(color),
> Qt::BackgroundRole);
>
Thanks Ceco!
The patch is applied.
Yordan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 16:11 [PATCH] KernelShark: Add guest's stream ID to the combobox item Tzvetomir Stoyanov (VMware)
2020-09-03 13:53 ` Yordan Karadzhov (VMware)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).