linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* trace-cmd profile is not working
@ 2021-05-12 13:51 Jerome Marchand
  2021-05-12 13:55 ` Steven Rostedt
  0 siblings, 1 reply; 6+ messages in thread
From: Jerome Marchand @ 2021-05-12 13:51 UTC (permalink / raw)
  To: linux-trace-devel; +Cc: Tzvetomir Stoyanov, Steven Rostedt

Hi,

Streams, and thus trace-cmd profile, are not working. A simple
"trace-cmd profile ls" command exit with the following message
"Creating stream for 0". I've been looking at it and the issue is that 
tracecmd_read_headers() tries to read the cmdlines, cpus and options 
sections that have not been written to the temporary file when called 
from trace_stream_init().

AFAICT, it is caused by the two following patches:

commit 1eea02a4 ("trace-cmd: Write saved cmdlines in the trace file at
the end of the trace.") which moved the writing of cmdlines from
create_file_fd() to tracecmd_create_file_latency() and
tracecmd_append_cpu_data()

commit 5d4d7ec3 ("trace-cmd: Move reading of trace.dat options to
tracecmd_read_headers()") which moved the reading of options and cpu
datas to tracecmd_read_headers().

Thanks,
Jerome


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: trace-cmd profile is not working
  2021-05-12 13:51 trace-cmd profile is not working Jerome Marchand
@ 2021-05-12 13:55 ` Steven Rostedt
  2021-05-12 14:09   ` Jerome Marchand
  0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2021-05-12 13:55 UTC (permalink / raw)
  To: Jerome Marchand; +Cc: linux-trace-devel, Tzvetomir Stoyanov

On Wed, 12 May 2021 15:51:52 +0200
Jerome Marchand <jmarchan@redhat.com> wrote:

> Hi,
> 
> Streams, and thus trace-cmd profile, are not working. A simple
> "trace-cmd profile ls" command exit with the following message
> "Creating stream for 0". I've been looking at it and the issue is that 
> tracecmd_read_headers() tries to read the cmdlines, cpus and options 
> sections that have not been written to the temporary file when called 
> from trace_stream_init().
> 
> AFAICT, it is caused by the two following patches:
> 
> commit 1eea02a4 ("trace-cmd: Write saved cmdlines in the trace file at
> the end of the trace.") which moved the writing of cmdlines from
> create_file_fd() to tracecmd_create_file_latency() and
> tracecmd_append_cpu_data()
> 
> commit 5d4d7ec3 ("trace-cmd: Move reading of trace.dat options to
> tracecmd_read_headers()") which moved the reading of options and cpu
> datas to tracecmd_read_headers().
> 

Thanks for the report. I'm not surprised, profiling and streams have not
been given the love they deserve (been focusing on host/guest tracing
recently).

Can you fill out a bug report on bugzilla?

  https://bugzilla.kernel.org/buglist.cgi?component=Trace-cmd%2FKernelshark&list_id=1090417&product=Tools&resolution=---

Thanks!

-- Steve

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: trace-cmd profile is not working
  2021-05-12 13:55 ` Steven Rostedt
@ 2021-05-12 14:09   ` Jerome Marchand
  2021-05-12 15:15     ` Steven Rostedt
  2021-05-14  7:56     ` Tzvetomir Stoyanov
  0 siblings, 2 replies; 6+ messages in thread
From: Jerome Marchand @ 2021-05-12 14:09 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linux-trace-devel, Tzvetomir Stoyanov

On 12/05/2021 15:55, Steven Rostedt wrote:
> On Wed, 12 May 2021 15:51:52 +0200
> Jerome Marchand <jmarchan@redhat.com> wrote:
> 
>> Hi,
>>
>> Streams, and thus trace-cmd profile, are not working. A simple
>> "trace-cmd profile ls" command exit with the following message
>> "Creating stream for 0". I've been looking at it and the issue is that
>> tracecmd_read_headers() tries to read the cmdlines, cpus and options
>> sections that have not been written to the temporary file when called
>> from trace_stream_init().
>>
>> AFAICT, it is caused by the two following patches:
>>
>> commit 1eea02a4 ("trace-cmd: Write saved cmdlines in the trace file at
>> the end of the trace.") which moved the writing of cmdlines from
>> create_file_fd() to tracecmd_create_file_latency() and
>> tracecmd_append_cpu_data()
>>
>> commit 5d4d7ec3 ("trace-cmd: Move reading of trace.dat options to
>> tracecmd_read_headers()") which moved the reading of options and cpu
>> datas to tracecmd_read_headers().
>>
> 
> Thanks for the report. I'm not surprised, profiling and streams have not
> been given the love they deserve (been focusing on host/guest tracing
> recently).
> 
> Can you fill out a bug report on bugzilla?

Sure thing:
https://bugzilla.kernel.org/show_bug.cgi?id=213045

Jerome

> 
>    https://bugzilla.kernel.org/buglist.cgi?component=Trace-cmd%2FKernelshark&list_id=1090417&product=Tools&resolution=---
> 
> Thanks!
> 
> -- Steve
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: trace-cmd profile is not working
  2021-05-12 14:09   ` Jerome Marchand
@ 2021-05-12 15:15     ` Steven Rostedt
  2021-05-14  7:56     ` Tzvetomir Stoyanov
  1 sibling, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2021-05-12 15:15 UTC (permalink / raw)
  To: Jerome Marchand; +Cc: linux-trace-devel, Tzvetomir Stoyanov

On Wed, 12 May 2021 16:09:01 +0200
Jerome Marchand <jmarchan@redhat.com> wrote:

> Sure thing:
> https://bugzilla.kernel.org/show_bug.cgi?id=213045

Thanks,

We are working on some other aspects now, but will try to have this fixed
before we do another release.

-- Steve

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: trace-cmd profile is not working
  2021-05-12 14:09   ` Jerome Marchand
  2021-05-12 15:15     ` Steven Rostedt
@ 2021-05-14  7:56     ` Tzvetomir Stoyanov
  2021-05-14 10:44       ` Jerome Marchand
  1 sibling, 1 reply; 6+ messages in thread
From: Tzvetomir Stoyanov @ 2021-05-14  7:56 UTC (permalink / raw)
  To: Jerome Marchand; +Cc: Steven Rostedt, Linux Trace Devel

Hi Jerome,

On Wed, May 12, 2021 at 5:09 PM Jerome Marchand <jmarchan@redhat.com> wrote:
>
> On 12/05/2021 15:55, Steven Rostedt wrote:
> > On Wed, 12 May 2021 15:51:52 +0200
> > Jerome Marchand <jmarchan@redhat.com> wrote:
> >
> >> Hi,
> >>
> >> Streams, and thus trace-cmd profile, are not working. A simple
> >> "trace-cmd profile ls" command exit with the following message
> >> "Creating stream for 0". I've been looking at it and the issue is that
> >> tracecmd_read_headers() tries to read the cmdlines, cpus and options
> >> sections that have not been written to the temporary file when called
> >> from trace_stream_init().
> >>
> >> AFAICT, it is caused by the two following patches:
> >>
> >> commit 1eea02a4 ("trace-cmd: Write saved cmdlines in the trace file at
> >> the end of the trace.") which moved the writing of cmdlines from
> >> create_file_fd() to tracecmd_create_file_latency() and
> >> tracecmd_append_cpu_data()
> >>
> >> commit 5d4d7ec3 ("trace-cmd: Move reading of trace.dat options to
> >> tracecmd_read_headers()") which moved the reading of options and cpu
> >> datas to tracecmd_read_headers().
> >>
> >
> > Thanks for the report. I'm not surprised, profiling and streams have not
> > been given the love they deserve (been focusing on host/guest tracing
> > recently).
> >
> > Can you fill out a bug report on bugzilla?
>
> Sure thing:
> https://bugzilla.kernel.org/show_bug.cgi?id=213045
>
> Jerome
>
> >
> >    https://bugzilla.kernel.org/buglist.cgi?component=Trace-cmd%2FKernelshark&list_id=1090417&product=Tools&resolution=---
> >
> > Thanks!
> >

I've submitted a fix for this, please can you verify if it fixes the problem.
Thanks for testing this code and reporting bugs!

> > -- Steve
> >
>


-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: trace-cmd profile is not working
  2021-05-14  7:56     ` Tzvetomir Stoyanov
@ 2021-05-14 10:44       ` Jerome Marchand
  0 siblings, 0 replies; 6+ messages in thread
From: Jerome Marchand @ 2021-05-14 10:44 UTC (permalink / raw)
  To: Tzvetomir Stoyanov; +Cc: Steven Rostedt, Linux Trace Devel

On 14/05/2021 09:56, Tzvetomir Stoyanov wrote:
> Hi Jerome,
> 
> On Wed, May 12, 2021 at 5:09 PM Jerome Marchand <jmarchan@redhat.com> wrote:
>>
>> On 12/05/2021 15:55, Steven Rostedt wrote:
>>> On Wed, 12 May 2021 15:51:52 +0200
>>> Jerome Marchand <jmarchan@redhat.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Streams, and thus trace-cmd profile, are not working. A simple
>>>> "trace-cmd profile ls" command exit with the following message
>>>> "Creating stream for 0". I've been looking at it and the issue is that
>>>> tracecmd_read_headers() tries to read the cmdlines, cpus and options
>>>> sections that have not been written to the temporary file when called
>>>> from trace_stream_init().
>>>>
>>>> AFAICT, it is caused by the two following patches:
>>>>
>>>> commit 1eea02a4 ("trace-cmd: Write saved cmdlines in the trace file at
>>>> the end of the trace.") which moved the writing of cmdlines from
>>>> create_file_fd() to tracecmd_create_file_latency() and
>>>> tracecmd_append_cpu_data()
>>>>
>>>> commit 5d4d7ec3 ("trace-cmd: Move reading of trace.dat options to
>>>> tracecmd_read_headers()") which moved the reading of options and cpu
>>>> datas to tracecmd_read_headers().
>>>>
>>>
>>> Thanks for the report. I'm not surprised, profiling and streams have not
>>> been given the love they deserve (been focusing on host/guest tracing
>>> recently).
>>>
>>> Can you fill out a bug report on bugzilla?
>>
>> Sure thing:
>> https://bugzilla.kernel.org/show_bug.cgi?id=213045
>>
>> Jerome
>>
>>>
>>>     https://bugzilla.kernel.org/buglist.cgi?component=Trace-cmd%2FKernelshark&list_id=1090417&product=Tools&resolution=---
>>>
>>> Thanks!
>>>
> 
> I've submitted a fix for this, please can you verify if it fixes the problem.
> Thanks for testing this code and reporting bugs!

Yes, it does fixes the issue have been seeing.

Thanks,
Jerome

> 
>>> -- Steve
>>>
>>
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-14 10:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 13:51 trace-cmd profile is not working Jerome Marchand
2021-05-12 13:55 ` Steven Rostedt
2021-05-12 14:09   ` Jerome Marchand
2021-05-12 15:15     ` Steven Rostedt
2021-05-14  7:56     ` Tzvetomir Stoyanov
2021-05-14 10:44       ` Jerome Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).