From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] kernel-shark: Don't try to update the markers if no data is loaded
Date: Thu, 18 Jul 2019 16:51:39 +0300 [thread overview]
Message-ID: <8bd7baaf-0bc9-4023-867b-9f2d77562034@gmail.com> (raw)
In-Reply-To: <20190717153014.2de929ef@gandalf.local.home>
On 17.07.19 г. 22:30 ч., Steven Rostedt wrote:
> On Mon, 15 Jul 2019 16:20:42 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
>
>> This change aims to avoid showing the labels of the time axis (zeros)
>> when no data is loaded.
>
> What is this actually fixing? I don't see a difference with adding this
> patch and without it.
>
Before applying the patch, try to open the GUI without a .dat file. Then
try to change the marker by pressing one of the marker's buttons. This
will try to update the labels of the time axis. But because no data is
loaded and nothing is plotted you will see only zeros at the place where
the time axis is supposed to be plotted.
Thanks!
Yordan
> -- Steve
>
>>
>> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
>>
prev parent reply other threads:[~2019-07-18 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 13:20 [PATCH 0/3] Fixes needed befor KS 1.0 Yordan Karadzhov (VMware)
2019-07-15 13:20 ` [PATCH 1/3] kernel-shark: The graph widget must follow the active marker Yordan Karadzhov (VMware)
2019-07-15 13:20 ` [PATCH 2/3] kernel-shark: Always clear the marker after resizing the table Yordan Karadzhov (VMware)
2019-07-15 13:20 ` [PATCH 3/3] kernel-shark: Don't try to update the markers if no data is loaded Yordan Karadzhov (VMware)
2019-07-17 19:30 ` Steven Rostedt
2019-07-18 13:51 ` Yordan Karadzhov (VMware) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd7baaf-0bc9-4023-867b-9f2d77562034@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).