* [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
@ 2023-02-28 13:01 Nick Alcock
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules Nick Alcock
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Nick Alcock @ 2023-02-28 13:01 UTC (permalink / raw)
To: mcgrof
Cc: linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
This series, based on current modules-next, is part of a treewide cleanup
suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
files/objects that are not tristate. Due to recent changes to kbuild, these
uses are now problematic. See the commit logs for more details.
(The commit log prefixes and Cc lists are automatically determined. I've
eyeballed them, and they seem reasonable: my apologies if they are not.)
I'll be sending a sixth and final tranche in a few days. (In total, there are 121
patches in this series.)
The series at a whole can be found here:
https://github.com/nickalcock/linux module-license
(This is a respin with kbuild: prefixes dropped. The previous series,
used in the mailouts of tranche 3 and earlier, is in the
module-license-kbuild-prefix branch.)
Cc: linux-clk@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-modules@vger.kernel.org
Cc: linux-perf-users@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: linux-trace-devel@vger.kernel.org
Cc: linux-trace-kernel@vger.kernel.org
Nick Alcock (20):
perf/hw_breakpoint: remove MODULE_LICENSE in non-modules
pinctrl: amd: remove MODULE_LICENSE in non-modules
pinctrl: mediatek: remove MODULE_LICENSE in non-modules
pinctrl: renesas: remove MODULE_LICENSE in non-modules
lib: remove MODULE_LICENSE in non-modules
powercap: remove MODULE_LICENSE in non-modules
power: supply: remove MODULE_LICENSE in non-modules
remoteproc: remove MODULE_LICENSE in non-modules
clk: renesas: remove MODULE_LICENSE in non-modules
reset: mchp: sparx5: remove MODULE_LICENSE in non-modules
reset: lantiq: remove MODULE_LICENSE in non-modules
clk: microchip: mpfs: remove MODULE_LICENSE in non-modules
reset: remove MODULE_LICENSE in non-modules
rv/reactor: remove MODULE_LICENSE in non-modules
tty: serial: imx: remove MODULE_LICENSE in non-modules
irqchip/irq-sl28cpld: remove MODULE_LICENSE in non-modules
ARC: reset: remove MODULE_LICENSE in non-modules
ARC: reset: remove MODULE_LICENSE in non-modules
power: reset: remove MODULE_LICENSE in non-modules
soc/tegra: cbb: remove MODULE_LICENSE in non-modules
drivers/clk/microchip/clk-mpfs.c | 1 -
drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
drivers/clk/renesas/renesas-cpg-mssr.c | 1 -
drivers/clk/renesas/rzg2l-cpg.c | 1 -
drivers/irqchip/irq-sl28cpld.c | 1 -
drivers/pinctrl/mediatek/pinctrl-mt8188.c | 1 -
drivers/pinctrl/mediatek/pinctrl-mt8192.c | 1 -
drivers/pinctrl/mediatek/pinctrl-mt8365.c | 1 -
drivers/pinctrl/pinctrl-amd.c | 1 -
drivers/pinctrl/renesas/pinctrl-rza1.c | 1 -
drivers/pinctrl/renesas/pinctrl-rza2.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzg2l.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzn1.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzv2m.c | 1 -
drivers/power/reset/as3722-poweroff.c | 1 -
drivers/power/reset/gpio-poweroff.c | 1 -
drivers/power/reset/gpio-restart.c | 1 -
drivers/power/reset/ltc2952-poweroff.c | 1 -
drivers/power/reset/regulator-poweroff.c | 1 -
drivers/power/reset/restart-poweroff.c | 1 -
drivers/power/reset/tps65086-restart.c | 1 -
drivers/power/supply/power_supply_core.c | 1 -
drivers/power/supply/wm97xx_battery.c | 1 -
drivers/powercap/powercap_sys.c | 1 -
drivers/remoteproc/remoteproc_core.c | 1 -
drivers/reset/reset-axs10x.c | 1 -
drivers/reset/reset-hsdk.c | 1 -
drivers/reset/reset-lantiq.c | 1 -
drivers/reset/reset-microchip-sparx5.c | 1 -
drivers/reset/reset-mpfs.c | 1 -
drivers/soc/tegra/cbb/tegra194-cbb.c | 1 -
drivers/soc/tegra/cbb/tegra234-cbb.c | 1 -
drivers/tty/serial/imx_earlycon.c | 1 -
kernel/events/hw_breakpoint_test.c | 1 -
kernel/trace/rv/reactor_panic.c | 1 -
kernel/trace/rv/reactor_printk.c | 1 -
lib/pldmfw/pldmfw.c | 1 -
37 files changed, 37 deletions(-)
--
2.39.1.268.g9de2f9a303
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:19 ` Daniel Bristot de Oliveira
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
2023-03-09 16:14 ` Greg KH
2 siblings, 1 reply; 6+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa,
Daniel Bristot de Oliveira, Steven Rostedt, Masami Hiramatsu,
linux-trace-devel, linux-trace-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-trace-devel@vger.kernel.org
Cc: linux-trace-kernel@vger.kernel.org
---
kernel/trace/rv/reactor_panic.c | 1 -
kernel/trace/rv/reactor_printk.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c
index d65f6c25a87cd..0186ff4cbd0b4 100644
--- a/kernel/trace/rv/reactor_panic.c
+++ b/kernel/trace/rv/reactor_panic.c
@@ -38,6 +38,5 @@ static void __exit unregister_react_panic(void)
module_init(register_react_panic);
module_exit(unregister_react_panic);
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Daniel Bristot de Oliveira");
MODULE_DESCRIPTION("panic rv reactor: panic if an exception is found.");
diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_printk.c
index 4b6b7106a477c..178759dbf89f5 100644
--- a/kernel/trace/rv/reactor_printk.c
+++ b/kernel/trace/rv/reactor_printk.c
@@ -37,6 +37,5 @@ static void __exit unregister_react_printk(void)
module_init(register_react_printk);
module_exit(unregister_react_printk);
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Daniel Bristot de Oliveira");
MODULE_DESCRIPTION("printk rv reactor: printk if an exception is hit.");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-28 13:19 ` Daniel Bristot de Oliveira
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Bristot de Oliveira @ 2023-02-28 13:19 UTC (permalink / raw)
To: Nick Alcock, mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Steven Rostedt,
Masami Hiramatsu, linux-trace-devel, linux-trace-kernel
On 2/28/23 10:02, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
-- Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-28 13:47 ` Geert Uytterhoeven
2023-03-20 11:06 ` Nick Alcock
2023-03-09 16:14 ` Greg KH
2 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2023-02-28 13:47 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
Hi Nick,
On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Does this mean you expect us to queue them for v6.3?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-09 16:14 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2023-03-09 16:14 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
On Tue, Feb 28, 2023 at 01:01:55PM +0000, Nick Alcock wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Why isn't kbuild fixed instead? These files can have MODULE_AUTHOR()
and other macros when built into the kernel, what is so special about
MODULE_LICENSE() that prevents this from working properly?
There should not be a need to remove these markings in my opinion, why
treat one MODULE_* macro more special than others?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-20 11:06 ` Nick Alcock
0 siblings, 0 replies; 6+ messages in thread
From: Nick Alcock @ 2023-03-20 11:06 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nick Alcock, mcgrof, linux-clk, linux-gpio, linux-kernel,
linux-modules, linux-perf-users, linux-pm, linux-remoteproc,
linux-renesas-soc, linux-riscv, linux-serial, linux-tegra,
linux-trace-devel, linux-trace-kernel
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> This series, based on current modules-next, is part of a treewide cleanup
>> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
>> files/objects that are not tristate. Due to recent changes to kbuild, these
>> uses are now problematic. See the commit logs for more details.
>
> Does this mean you expect us to queue them for v6.3?
> Thanks!
I believe Luis is planning to pull them in around -rc3, hence my
freshening the series up now, getting everyone's tags in, etc.
--
NULL && (void)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-20 11:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-28 13:19 ` Daniel Bristot de Oliveira
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
2023-03-20 11:06 ` Nick Alcock
2023-03-09 16:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).