From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Srinivasarao Pathipati <quic_c_spathi@quicinc.com>
Cc: Richard Weinberger <richard@nod.at>,
anton ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um <linux-um@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1] um: Fix compilation warnings
Date: Wed, 15 Feb 2023 09:07:21 +0100 [thread overview]
Message-ID: <CAMuHMdUb9cduEae2vzX8LeVG7z0nRrKHrQN6UGJ_YLuWOBbKOg@mail.gmail.com> (raw)
In-Reply-To: <913fea79-09f9-b976-ff1a-cd833784abb6@quicinc.com>
Hi Srinivasarao,
On Wed, Feb 15, 2023 at 6:36 AM Srinivasarao Pathipati
<quic_c_spathi@quicinc.com> wrote:
> On 2/15/2023 3:27 AM, Richard Weinberger wrote:
> > ----- Ursprüngliche Mail -----
> >> Von: "Srinivasarao Pathipati" <quic_c_spathi@quicinc.com>
> >> static void sig_handler_common(int sig, struct siginfo *si, mcontext_t *mc)
> >> {
> >> - struct uml_pt_regs r;
> >> + struct uml_pt_regs *r;
> >> int save_errno = errno;
> >>
> >> - r.is_user = 0;
> >> + r = malloc(sizeof(struct uml_pt_regs));
> > I fear this is not correct since malloc() is not async-signal safe.
>
> Thanks Richard for quick response. Could you please suggest alternative
> function of malloc() with async-signal safe.
>
> if that is not possible Is there any other way to fix this warning? OR
> do we need to live with that warning?
Does this limit actually apply to this file, which calls into the host OS?
How come you even see this warning, as we have
CFLAGS_signal.o += -Wframe-larger-than=4096
since commit 517f60206ee5d5f7 ("um: Increase stack frame size threshold
for signal.c") in v5.11?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-02-15 8:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 21:30 [PATCH V1] um: Fix compilation warnings Srinivasarao Pathipati
2023-02-14 21:57 ` Richard Weinberger
2023-02-15 5:35 ` Srinivasarao Pathipati
2023-02-15 8:07 ` Geert Uytterhoeven [this message]
2023-02-15 8:13 ` Johannes Berg
2023-02-15 8:14 ` Srinivasarao Pathipati
2023-02-15 8:14 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUb9cduEae2vzX8LeVG7z0nRrKHrQN6UGJ_YLuWOBbKOg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=quic_c_spathi@quicinc.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).