* [PATCH v2] um: vector: Fix memory leak in vector_config
@ 2023-01-04 8:14 Miaoqian Lin
2023-01-04 8:29 ` Anton Ivanov
2023-01-04 10:17 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2023-01-04 8:14 UTC (permalink / raw)
To: Richard Weinberger, Anton Ivanov, Johannes Berg, Miaoqian Lin,
Wolfram Sang, David S. Miller, Jakub Kicinski, linux-um,
linux-kernel
kstrdup() return newly allocated copy of the string.
Call kfree() to release the memory when uml_parse_vector_ifspec() fails.
Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- only call kfree() when uml_parse_vector_ifspec() fails.
---
arch/um/drivers/vector_kern.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index ded7c47d2fbe..131b7cb29576 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out)
if (parsed == NULL) {
*error_out = "vector_config failed to parse parameters";
+ kfree(params);
return -EINVAL;
}
--
2.25.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] um: vector: Fix memory leak in vector_config
2023-01-04 8:14 [PATCH v2] um: vector: Fix memory leak in vector_config Miaoqian Lin
@ 2023-01-04 8:29 ` Anton Ivanov
2023-01-04 10:17 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Anton Ivanov @ 2023-01-04 8:29 UTC (permalink / raw)
To: Miaoqian Lin, Richard Weinberger, Johannes Berg, Wolfram Sang,
David S. Miller, Jakub Kicinski, linux-um, linux-kernel
On 04/01/2023 08:14, Miaoqian Lin wrote:
> kstrdup() return newly allocated copy of the string.
> Call kfree() to release the memory when uml_parse_vector_ifspec() fails.
>
> Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> changes in v2:
> - only call kfree() when uml_parse_vector_ifspec() fails.
> ---
> arch/um/drivers/vector_kern.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index ded7c47d2fbe..131b7cb29576 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out)
>
> if (parsed == NULL) {
> *error_out = "vector_config failed to parse parameters";
> + kfree(params);
> return -EINVAL;
> }
>
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] um: vector: Fix memory leak in vector_config
2023-01-04 8:14 [PATCH v2] um: vector: Fix memory leak in vector_config Miaoqian Lin
2023-01-04 8:29 ` Anton Ivanov
@ 2023-01-04 10:17 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-01-04 10:17 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Richard Weinberger, Anton Ivanov, Johannes Berg, Wolfram Sang,
David S. Miller, Jakub Kicinski, linux-um, linux-kernel
On Wed, Jan 4, 2023 at 9:18 AM Miaoqian Lin <linmq006@gmail.com> wrote:
> kstrdup() return newly allocated copy of the string.
> Call kfree() to release the memory when uml_parse_vector_ifspec() fails.
>
> Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> changes in v2:
> - only call kfree() when uml_parse_vector_ifspec() fails.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-04 10:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04 8:14 [PATCH v2] um: vector: Fix memory leak in vector_config Miaoqian Lin
2023-01-04 8:29 ` Anton Ivanov
2023-01-04 10:17 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).