* [PATCH] input/misc: wistron_btns: disable on UML
@ 2022-11-30 16:16 Randy Dunlap
2022-11-30 23:16 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-11-30 16:16 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Johannes Berg, Richard Weinberger, Dmitry Torokhov,
Miloslav Trmac, linux-input, linux-um
The wistron_btns driver calls rtc_cmos_read(), which isn't
available with UML builds, so disable this driver on UML.
Prevents this build error:
ld: drivers/input/misc/wistron_btns.o: in function `poll_bios':
wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read'
Fixes: 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Miloslav Trmac <mitr@volny.cz>
Cc: linux-input@vger.kernel.org
Cc: linux-um@lists.infradead.org
---
drivers/input/misc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -330,7 +330,7 @@ config INPUT_CPCAP_PWRBUTTON
config INPUT_WISTRON_BTNS
tristate "x86 Wistron laptop button interface"
- depends on X86_32
+ depends on X86_32 && !UML
select INPUT_SPARSEKMAP
select NEW_LEDS
select LEDS_CLASS
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] input/misc: wistron_btns: disable on UML
2022-11-30 16:16 [PATCH] input/misc: wistron_btns: disable on UML Randy Dunlap
@ 2022-11-30 23:16 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2022-11-30 23:16 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Johannes Berg, Richard Weinberger, Miloslav Trmac,
linux-input, linux-um
On Wed, Nov 30, 2022 at 08:16:04AM -0800, Randy Dunlap wrote:
> The wistron_btns driver calls rtc_cmos_read(), which isn't
> available with UML builds, so disable this driver on UML.
>
> Prevents this build error:
>
> ld: drivers/input/misc/wistron_btns.o: in function `poll_bios':
> wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read'
>
> Fixes: 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Miloslav Trmac <mitr@volny.cz>
> Cc: linux-input@vger.kernel.org
> Cc: linux-um@lists.infradead.org
Applied, thank you.
--
Dmitry
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-30 23:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-30 16:16 [PATCH] input/misc: wistron_btns: disable on UML Randy Dunlap
2022-11-30 23:16 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).