* [PATCH] generic/486: filter out irrelevant attrs
@ 2019-06-27 9:00 Murphy Zhou
2019-06-27 15:25 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Murphy Zhou @ 2019-06-27 9:00 UTC (permalink / raw)
To: fstests; +Cc: darrick.wong, linux-unionfs, miklos, Murphy Zhou
In some setup, there could be extra attrs printed, like selinux.
They are breaking golden output and irrelevant for this test.
So focus on the attr we are testing on to avoid false alarm.
Print the output to .full for debug.
Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
tests/generic/486 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/generic/486 b/tests/generic/486
index ff115a07..ea571efe 100755
--- a/tests/generic/486
+++ b/tests/generic/486
@@ -46,10 +46,12 @@ _scratch_mkfs >>$seqres.full 2>&1
_scratch_mount >>$seqres.full 2>&1
filter_attr_output() {
- _filter_scratch | sed -e 's/has a [0-9]* byte value/has a NNNN byte value/g'
+ _filter_scratch | grep world | \
+ sed -e 's/has a [0-9]* byte value/has a NNNN byte value/g'
}
./src/attr_replace_test $SCRATCH_MNT/hello
+$ATTR_PROG -l $SCRATCH_MNT/hello >>$seqres.full 2>&1
$ATTR_PROG -l $SCRATCH_MNT/hello | filter_attr_output
status=0
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/486: filter out irrelevant attrs
2019-06-27 9:00 [PATCH] generic/486: filter out irrelevant attrs Murphy Zhou
@ 2019-06-27 15:25 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-06-27 15:25 UTC (permalink / raw)
To: Murphy Zhou; +Cc: fstests, linux-unionfs, miklos
On Thu, Jun 27, 2019 at 05:00:59PM +0800, Murphy Zhou wrote:
> In some setup, there could be extra attrs printed, like selinux.
> They are breaking golden output and irrelevant for this test.
> So focus on the attr we are testing on to avoid false alarm.
> Print the output to .full for debug.
>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/generic/486 | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/generic/486 b/tests/generic/486
> index ff115a07..ea571efe 100755
> --- a/tests/generic/486
> +++ b/tests/generic/486
> @@ -46,10 +46,12 @@ _scratch_mkfs >>$seqres.full 2>&1
> _scratch_mount >>$seqres.full 2>&1
>
> filter_attr_output() {
> - _filter_scratch | sed -e 's/has a [0-9]* byte value/has a NNNN byte value/g'
> + _filter_scratch | grep world | \
> + sed -e 's/has a [0-9]* byte value/has a NNNN byte value/g'
> }
>
> ./src/attr_replace_test $SCRATCH_MNT/hello
> +$ATTR_PROG -l $SCRATCH_MNT/hello >>$seqres.full 2>&1
> $ATTR_PROG -l $SCRATCH_MNT/hello | filter_attr_output
>
> status=0
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-27 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 9:00 [PATCH] generic/486: filter out irrelevant attrs Murphy Zhou
2019-06-27 15:25 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).