($INBOX_DIR/description missing)
 help / color / Atom feed
* [RFC PATCH v3] overlayfs: Provide mount options sync=off/fs to skip sync
@ 2020-07-01 21:50 Vivek Goyal
  2020-07-02  7:26 ` Amir Goldstein
  0 siblings, 1 reply; 3+ messages in thread
From: Vivek Goyal @ 2020-07-01 21:50 UTC (permalink / raw)
  To: amir73il, linux-unionfs, miklos
  Cc: Giuseppe Scrivano, Daniel J Walsh, Steven Whitehouse,
	Eric Sandeen, pmatilai

Container folks are complaining that dnf/yum issues too many sync while
installing packages and this slows down the image build. Build
requirement is such that they don't care if a node goes down while
build was still going on. In that case, they will simply throw away
unfinished layer and start new build. So they don't care about syncing
intermediate state to the disk and hence don't want to pay the price
associated with sync.

So they are asking for mount options where they can disable sync on overlay
mount point.

They primarily seem to have two use cases.

- For building images, they will mount overlay with nosync and then sync
  upper layer after unmounting overlay and reuse upper as lower for next
  layer.

- For running containers, they don't seem to care about syncing upper
  layer because if node goes down, they will simply throw away upper
  layer and create a fresh one.

So this patch provides two mount options "sync=off" and "sync=fs".
First option disables all forms of sync. Now it is caller's responsibility
to throw away upper if system crashes or shuts down and start fresh.

Option "sync=fs" disables all forms of sync except syncfs/umount/remount.
This is basically useful for image build where we want to persist upper
layer only after operation is complete and upper will be renamed and
reused as lower for next layer build.

With sync=off, I am seeing roughly 20% speed up in my VM where I am just
installing emacs in an image. Installation time drops from 31 seconds to
25 seconds when nosync option is used. This is for the case of building on top
of an image where all packages are already cached. That way I take
out the network operations latency out of the measurement.

With sync=fs, I am seeing roughly 12% speed up.

Giuseppe is also looking to cut down on number of iops done on the
disk. He is complaining that often in cloud their VMs are throttled
if they cross the limit. This option can help them where they reduce
number of iops (by cutting down on frequent sync and writebacks).

Changes from v2:
- Added helper functions (Amir Goldstein)
- Used enums to keep sync state (Amir Goldstein)

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 Documentation/filesystems/overlayfs.rst | 16 +++++++++++
 fs/overlayfs/copy_up.c                  | 12 +++++---
 fs/overlayfs/file.c                     | 10 ++++++-
 fs/overlayfs/ovl_entry.h                | 20 +++++++++++++
 fs/overlayfs/readdir.c                  |  3 ++
 fs/overlayfs/super.c                    | 37 +++++++++++++++++++++++--
 6 files changed, 90 insertions(+), 8 deletions(-)

diff --git a/Documentation/filesystems/overlayfs.rst b/Documentation/filesystems/overlayfs.rst
index 660dbaf0b9b8..4e55ac4433ec 100644
--- a/Documentation/filesystems/overlayfs.rst
+++ b/Documentation/filesystems/overlayfs.rst
@@ -563,6 +563,22 @@ This verification may cause significant overhead in some cases.
 Note: the mount options index=off,nfs_export=on are conflicting and will
 result in an error.
 
+Disable sync
+------------
+By default, overlay skips sync on files residing on a lower layer.  It
+is possible to skip sync operations for files on the upper layer as well
+with the "sync=off" and "sync=fs" mount option.
+
+"sync=off" option disables all forms of sync from overlay, including the
+one done at umount/remount. If system crashes or shuts down, user
+should throw away upper directory and start fresh.
+
+"sync=fs" option disables all forms of sync except full filesystem
+sync which is done at syncfs/remount/mount time. This is useful for
+use cases like container image build which want upper to persist
+only if operation has finished. If system crashes before image
+layer formation is complete, tools should discard upper and start
+fresh.
 
 Testsuite
 ---------
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 79dd052c7dbf..3a5ae9c2f86e 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -128,7 +128,8 @@ int ovl_copy_xattr(struct dentry *old, struct dentry *new)
 	return error;
 }
 
-static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len)
+static int ovl_copy_up_data(struct ovl_fs *ofs, struct path *old,
+			    struct path *new, loff_t len)
 {
 	struct file *old_file;
 	struct file *new_file;
@@ -218,7 +219,7 @@ static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len)
 		len -= bytes;
 	}
 out:
-	if (!error)
+	if (!error && ovl_should_fsync(ofs))
 		error = vfs_fsync(new_file, 0);
 	fput(new_file);
 out_fput:
@@ -484,6 +485,7 @@ static int ovl_link_up(struct ovl_copy_up_ctx *c)
 
 static int ovl_copy_up_inode(struct ovl_copy_up_ctx *c, struct dentry *temp)
 {
+	struct ovl_fs *ofs = OVL_FS(c->dentry->d_sb);
 	int err;
 
 	/*
@@ -499,7 +501,8 @@ static int ovl_copy_up_inode(struct ovl_copy_up_ctx *c, struct dentry *temp)
 		upperpath.dentry = temp;
 
 		ovl_path_lowerdata(c->dentry, &datapath);
-		err = ovl_copy_up_data(&datapath, &upperpath, c->stat.size);
+		err = ovl_copy_up_data(ofs, &datapath, &upperpath,
+				       c->stat.size);
 		if (err)
 			return err;
 	}
@@ -784,6 +787,7 @@ static bool ovl_need_meta_copy_up(struct dentry *dentry, umode_t mode,
 /* Copy up data of an inode which was copied up metadata only in the past. */
 static int ovl_copy_up_meta_inode_data(struct ovl_copy_up_ctx *c)
 {
+	struct ovl_fs *ofs = OVL_FS(c->dentry->d_sb);
 	struct path upperpath, datapath;
 	int err;
 	char *capability = NULL;
@@ -804,7 +808,7 @@ static int ovl_copy_up_meta_inode_data(struct ovl_copy_up_ctx *c)
 			goto out;
 	}
 
-	err = ovl_copy_up_data(&datapath, &upperpath, c->stat.size);
+	err = ovl_copy_up_data(ofs, &datapath, &upperpath, c->stat.size);
 	if (err)
 		goto out_free;
 
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index 01820e654a21..c92af3856dbf 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -329,6 +329,7 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
 	struct fd real;
 	const struct cred *old_cred;
 	ssize_t ret;
+	int ifl = iocb->ki_flags;
 
 	if (!iov_iter_count(iter))
 		return 0;
@@ -344,11 +345,14 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
 	if (ret)
 		goto out_unlock;
 
+	if (!ovl_should_fsync(OVL_FS(inode->i_sb)))
+		ifl &= ~(IOCB_DSYNC | IOCB_SYNC);
+
 	old_cred = ovl_override_creds(file_inode(file)->i_sb);
 	if (is_sync_kiocb(iocb)) {
 		file_start_write(real.file);
 		ret = vfs_iter_write(real.file, iter, &iocb->ki_pos,
-				     ovl_iocb_to_rwf(iocb->ki_flags));
+				     ovl_iocb_to_rwf(ifl));
 		file_end_write(real.file);
 		/* Update size */
 		ovl_copyattr(ovl_inode_real(inode), inode);
@@ -368,6 +372,7 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
 		real.flags = 0;
 		aio_req->orig_iocb = iocb;
 		kiocb_clone(&aio_req->iocb, iocb, real.file);
+		aio_req->iocb.ki_flags = ifl;
 		aio_req->iocb.ki_complete = ovl_aio_rw_complete;
 		ret = vfs_iocb_iter_write(real.file, &aio_req->iocb, iter);
 		if (ret != -EIOCBQUEUED)
@@ -431,6 +436,9 @@ static int ovl_fsync(struct file *file, loff_t start, loff_t end, int datasync)
 	const struct cred *old_cred;
 	int ret;
 
+	if (!ovl_should_fsync(OVL_FS(file_inode(file)->i_sb)))
+		return 0;
+
 	ret = ovl_real_fdget_meta(file, &real, !datasync);
 	if (ret)
 		return ret;
diff --git a/fs/overlayfs/ovl_entry.h b/fs/overlayfs/ovl_entry.h
index b429c80879ee..e7aea92733f5 100644
--- a/fs/overlayfs/ovl_entry.h
+++ b/fs/overlayfs/ovl_entry.h
@@ -5,6 +5,14 @@
  * Copyright (C) 2016 Red Hat, Inc.
  */
 
+enum ovl_sync_type {
+	__OVL_SYNC_OFF		= (1 << 0),
+	__OVL_SYNC_FS		= (1 << 1),
+};
+
+#define OVL_SYNC_OFF(type)	((type) & __OVL_SYNC_OFF)
+#define OVL_SYNC_FS(type)	((type) & __OVL_SYNC_FS)
+
 struct ovl_config {
 	char *lowerdir;
 	char *upperdir;
@@ -17,6 +25,7 @@ struct ovl_config {
 	bool nfs_export;
 	int xino;
 	bool metacopy;
+	enum ovl_sync_type sync;
 };
 
 struct ovl_sb {
@@ -90,6 +99,17 @@ static inline struct ovl_fs *OVL_FS(struct super_block *sb)
 	return (struct ovl_fs *)sb->s_fs_info;
 }
 
+static inline bool ovl_should_fsync(struct ovl_fs *ofs)
+{
+	return (!OVL_SYNC_OFF(ofs->config.sync) &&
+		! OVL_SYNC_FS(ofs->config.sync));
+}
+
+static inline bool ovl_should_syncfs(struct ovl_fs *ofs)
+{
+	return !OVL_SYNC_OFF(ofs->config.sync);
+}
+
 /* private information held for every overlayfs dentry */
 struct ovl_entry {
 	union {
diff --git a/fs/overlayfs/readdir.c b/fs/overlayfs/readdir.c
index 6918b98faeb6..80f772faad5c 100644
--- a/fs/overlayfs/readdir.c
+++ b/fs/overlayfs/readdir.c
@@ -863,6 +863,9 @@ static int ovl_dir_fsync(struct file *file, loff_t start, loff_t end,
 	if (!OVL_TYPE_UPPER(ovl_path_type(dentry)))
 		return 0;
 
+	if (!ovl_should_fsync(OVL_FS(dentry->d_sb)))
+		return 0;
+
 	/*
 	 * Need to check if we started out being a lower dir, but got copied up
 	 */
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 91476bc422f9..b7cd0d0cd39e 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -264,6 +264,8 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
 	if (!ovl_upper_mnt(ofs))
 		return 0;
 
+	if (!ovl_should_syncfs(ofs))
+		return 0;
 	/*
 	 * Not called for sync(2) call or an emergency sync (SB_I_SKIP_SYNC).
 	 * All the super blocks will be iterated, including upper_sb.
@@ -362,6 +364,10 @@ static int ovl_show_options(struct seq_file *m, struct dentry *dentry)
 	if (ofs->config.metacopy != ovl_metacopy_def)
 		seq_printf(m, ",metacopy=%s",
 			   ofs->config.metacopy ? "on" : "off");
+	if (OVL_SYNC_OFF(ofs->config.sync))
+		seq_puts(m, ",sync=off");
+	if (OVL_SYNC_FS(ofs->config.sync))
+		seq_puts(m, ",sync=fs");
 	return 0;
 }
 
@@ -376,9 +382,11 @@ static int ovl_remount(struct super_block *sb, int *flags, char *data)
 
 	if (*flags & SB_RDONLY && !sb_rdonly(sb)) {
 		upper_sb = ovl_upper_mnt(ofs)->mnt_sb;
-		down_read(&upper_sb->s_umount);
-		ret = sync_filesystem(upper_sb);
-		up_read(&upper_sb->s_umount);
+		if (ovl_should_syncfs(ofs)) {
+			down_read(&upper_sb->s_umount);
+			ret = sync_filesystem(upper_sb);
+			up_read(&upper_sb->s_umount);
+		}
 	}
 
 	return ret;
@@ -411,6 +419,8 @@ enum {
 	OPT_XINO_AUTO,
 	OPT_METACOPY_ON,
 	OPT_METACOPY_OFF,
+	OPT_SYNC_OFF,
+	OPT_SYNC_FS,
 	OPT_ERR,
 };
 
@@ -429,6 +439,8 @@ static const match_table_t ovl_tokens = {
 	{OPT_XINO_AUTO,			"xino=auto"},
 	{OPT_METACOPY_ON,		"metacopy=on"},
 	{OPT_METACOPY_OFF,		"metacopy=off"},
+	{OPT_SYNC_OFF,			"sync=off"},
+	{OPT_SYNC_FS,			"sync=fs"},
 	{OPT_ERR,			NULL}
 };
 
@@ -573,6 +585,14 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
 			metacopy_opt = true;
 			break;
 
+		case OPT_SYNC_OFF:
+			config->sync |= __OVL_SYNC_OFF;
+			break;
+
+		case OPT_SYNC_FS:
+			config->sync |= __OVL_SYNC_FS;
+			break;
+
 		default:
 			pr_err("unrecognized mount option \"%s\" or missing value\n",
 					p);
@@ -588,6 +608,17 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
 		config->workdir = NULL;
 	}
 
+	if (OVL_SYNC_OFF(config->sync) && OVL_SYNC_FS(config->sync)) {
+		pr_err("conflicting options: sync=off,sync=fs\n");
+		return -EINVAL;
+	}
+
+	if (!config->upperdir &&
+	    (OVL_SYNC_OFF(config->sync) || OVL_SYNC_FS(config->sync))) {
+		pr_info("option sync=off/fs is meaningless in a non-upper mount, ignoring it.\n");
+		config->sync = 0;
+	}
+
 	err = ovl_parse_redirect_mode(config, config->redirect_mode);
 	if (err)
 		return err;
-- 
2.25.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH v3] overlayfs: Provide mount options sync=off/fs to skip sync
  2020-07-01 21:50 [RFC PATCH v3] overlayfs: Provide mount options sync=off/fs to skip sync Vivek Goyal
@ 2020-07-02  7:26 ` Amir Goldstein
  2020-07-06 16:06   ` Vivek Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: Amir Goldstein @ 2020-07-02  7:26 UTC (permalink / raw)
  To: Vivek Goyal
  Cc: overlayfs, Miklos Szeredi, Giuseppe Scrivano, Daniel J Walsh,
	Steven Whitehouse, Eric Sandeen, pmatilai

On Thu, Jul 2, 2020 at 12:50 AM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> Container folks are complaining that dnf/yum issues too many sync while
> installing packages and this slows down the image build. Build
> requirement is such that they don't care if a node goes down while
> build was still going on. In that case, they will simply throw away
> unfinished layer and start new build. So they don't care about syncing
> intermediate state to the disk and hence don't want to pay the price
> associated with sync.
>
> So they are asking for mount options where they can disable sync on overlay
> mount point.
>
> They primarily seem to have two use cases.
>
> - For building images, they will mount overlay with nosync and then sync
>   upper layer after unmounting overlay and reuse upper as lower for next
>   layer.
>
> - For running containers, they don't seem to care about syncing upper
>   layer because if node goes down, they will simply throw away upper
>   layer and create a fresh one.
>
> So this patch provides two mount options "sync=off" and "sync=fs".
> First option disables all forms of sync. Now it is caller's responsibility
> to throw away upper if system crashes or shuts down and start fresh.
>
> Option "sync=fs" disables all forms of sync except syncfs/umount/remount.
> This is basically useful for image build where we want to persist upper
> layer only after operation is complete and upper will be renamed and
> reused as lower for next layer build.
>
> With sync=off, I am seeing roughly 20% speed up in my VM where I am just
> installing emacs in an image. Installation time drops from 31 seconds to
> 25 seconds when nosync option is used. This is for the case of building on top
> of an image where all packages are already cached. That way I take
> out the network operations latency out of the measurement.
>
> With sync=fs, I am seeing roughly 12% speed up.
>
> Giuseppe is also looking to cut down on number of iops done on the
> disk. He is complaining that often in cloud their VMs are throttled
> if they cross the limit. This option can help them where they reduce
> number of iops (by cutting down on frequent sync and writebacks).
>
> Changes from v2:
> - Added helper functions (Amir Goldstein)
> - Used enums to keep sync state (Amir Goldstein)

Thank you for doing that.
Sorry, but I failed to mention the practical reasons for suggesting the
enum config and you failed to read my mind :-/
So I will explain my reasoning using more words (see below)

>
> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

Anyway, you may add:
Reviewed-by: Amir Goldstein <amir73il@gmail.com>

> diff --git a/fs/overlayfs/ovl_entry.h b/fs/overlayfs/ovl_entry.h
> index b429c80879ee..e7aea92733f5 100644
> --- a/fs/overlayfs/ovl_entry.h
> +++ b/fs/overlayfs/ovl_entry.h
> @@ -5,6 +5,14 @@
>   * Copyright (C) 2016 Red Hat, Inc.
>   */
>
> +enum ovl_sync_type {
> +       __OVL_SYNC_OFF          = (1 << 0),
> +       __OVL_SYNC_FS           = (1 << 1),
> +};
> +
> +#define OVL_SYNC_OFF(type)     ((type) & __OVL_SYNC_OFF)
> +#define OVL_SYNC_FS(type)      ((type) & __OVL_SYNC_FS)
> +

My unspoken intention when I wrote either "enum" or "flags" is -

If you use bitwise flags, they reflect the ovl_should_xxx queries:
__OVL_NOSYNC_FILE and __OVL_NOSYNC_FS
#define OVL_SYNC_FILE(type)     (!((type) & __OVL_NOSYNC_FILE))
#define OVL_SYNC_FS(type)      (!((type) & __OVL_NOSYNC_FS))


If you use enum (not bitwise), the distinct enum values reflect the
mount option:
OVL_SYNC_ON (=0), OVL_SYNC_OFF, OVL_SYNC_FS

I am not commenting on this because of some sort of aesthetic taste.
I am commenting on this because I think it would make parts of the
patch simpler/clearer (see below).

As far as I am concerned, for the three possible config values off/fs/on
the distinct enum values are better.
Of course, that is *my* opinion. You may disagree.

>  struct ovl_config {
>         char *lowerdir;
>         char *upperdir;
> @@ -17,6 +25,7 @@ struct ovl_config {
>         bool nfs_export;
>         int xino;
>         bool metacopy;
> +       enum ovl_sync_type sync;
>  };
>
>  struct ovl_sb {
> @@ -90,6 +99,17 @@ static inline struct ovl_fs *OVL_FS(struct super_block *sb)
>         return (struct ovl_fs *)sb->s_fs_info;
>  }
>
> +static inline bool ovl_should_fsync(struct ovl_fs *ofs)
> +{
> +       return (!OVL_SYNC_OFF(ofs->config.sync) &&
> +               ! OVL_SYNC_FS(ofs->config.sync));

option #1 (bitwise):
return OVL_SYNC_FILE(ofs->config.sync);

option #2 (distinct):
return ofs->config.sync == OVL_SYNC_ON;

> +}
> +
> +static inline bool ovl_should_syncfs(struct ovl_fs *ofs)
> +{
> +       return !OVL_SYNC_OFF(ofs->config.sync);

option #1 (bitwise):
return OVL_SYNC_FS(ofs->config.sync);

option #2 (distinct):
return ofs->config.sync != OVL_SYNC_OFF;

[...]

> @@ -362,6 +364,10 @@ static int ovl_show_options(struct seq_file *m, struct dentry *dentry)
>         if (ofs->config.metacopy != ovl_metacopy_def)
>                 seq_printf(m, ",metacopy=%s",
>                            ofs->config.metacopy ? "on" : "off");
> +       if (OVL_SYNC_OFF(ofs->config.sync))
> +               seq_puts(m, ",sync=off");
> +       if (OVL_SYNC_FS(ofs->config.sync))
> +               seq_puts(m, ",sync=fs");

option #1 (bitwise):
       if (!ofs->config.sync)
               seq_puts(m, ",sync=off");
      else if (!OVL_SYNC_FILE(ofs->config.sync))
               seq_puts(m, ",sync=fs");

option #2 (distinct):
Would be better. See ovl_xino_str[].


> @@ -411,6 +419,8 @@ enum {
>         OPT_XINO_AUTO,
>         OPT_METACOPY_ON,
>         OPT_METACOPY_OFF,
> +       OPT_SYNC_OFF,
> +       OPT_SYNC_FS,
>         OPT_ERR,
>  };
>
> @@ -429,6 +439,8 @@ static const match_table_t ovl_tokens = {
>         {OPT_XINO_AUTO,                 "xino=auto"},
>         {OPT_METACOPY_ON,               "metacopy=on"},
>         {OPT_METACOPY_OFF,              "metacopy=off"},
> +       {OPT_SYNC_OFF,                  "sync=off"},
> +       {OPT_SYNC_FS,                   "sync=fs"},
>         {OPT_ERR,                       NULL}
>  };
>
> @@ -573,6 +585,14 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
>                         metacopy_opt = true;
>                         break;
>
> +               case OPT_SYNC_OFF:
> +                       config->sync |= __OVL_SYNC_OFF;

There is really no point in ORing with old config options here.

option #1 (bitwise):
                       config->sync = __OVL_NOSYNC_FILE | __OVL_NOSYNC_FS;

option #2 (distinct):
                       config->sync = OVL_SYNC_OFF;


> +                       break;
> +
> +               case OPT_SYNC_FS:
> +                       config->sync |= __OVL_SYNC_FS;
> +                       break;
> +
>                 default:
>                         pr_err("unrecognized mount option \"%s\" or missing value\n",
>                                         p);
> @@ -588,6 +608,17 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
>                 config->workdir = NULL;
>         }
>
> +       if (OVL_SYNC_OFF(config->sync) && OVL_SYNC_FS(config->sync)) {
> +               pr_err("conflicting options: sync=off,sync=fs\n");
> +               return -EINVAL;
> +       }
> +

We are not warning user that metacopy=off conflicts with metacopy=on,
we just let the last option overwrite previous ones.


> +       if (!config->upperdir &&
> +           (OVL_SYNC_OFF(config->sync) || OVL_SYNC_FS(config->sync))) {
> +               pr_info("option sync=off/fs is meaningless in a non-upper mount, ignoring it.\n");
> +               config->sync = 0;
> +       }
> +

With either bitwise/distinct options this could be simplified:

       if (!config->upperdir && config->sync)
               pr_info("option "sync=off/fs" is meaningless in a
non-upper mount, ignoring it.\n");
               config->sync = 0;

Thanks,
Amir.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH v3] overlayfs: Provide mount options sync=off/fs to skip sync
  2020-07-02  7:26 ` Amir Goldstein
@ 2020-07-06 16:06   ` Vivek Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Vivek Goyal @ 2020-07-06 16:06 UTC (permalink / raw)
  To: Amir Goldstein
  Cc: overlayfs, Miklos Szeredi, Giuseppe Scrivano, Daniel J Walsh,
	Steven Whitehouse, Eric Sandeen, pmatilai

On Thu, Jul 02, 2020 at 10:26:44AM +0300, Amir Goldstein wrote:
[..]
> If you use bitwise flags, they reflect the ovl_should_xxx queries:
> __OVL_NOSYNC_FILE and __OVL_NOSYNC_FS
> #define OVL_SYNC_FILE(type)     (!((type) & __OVL_NOSYNC_FILE))
> #define OVL_SYNC_FS(type)      (!((type) & __OVL_NOSYNC_FS))
> 
> 
> If you use enum (not bitwise), the distinct enum values reflect the
> mount option:
> OVL_SYNC_ON (=0), OVL_SYNC_OFF, OVL_SYNC_FS
> 
> I am not commenting on this because of some sort of aesthetic taste.
> I am commenting on this because I think it would make parts of the
> patch simpler/clearer (see below).
> 
> As far as I am concerned, for the three possible config values off/fs/on
> the distinct enum values are better.
> Of course, that is *my* opinion. You may disagree.

Hi Amir,

I kept bitwise flags because you had mentioned sync=writeback and this
can co-exist with sync=fs. May be somebody wants sync=copyup down the
line. Though we have not implemented sync=writeback
yet, I thought keeping a bitwise flag will help support multiple sync
options at the same time.

Anyway, sync=off/fs are mutually exclusive and don't need bitwise
flags. So for now I will convert this to just enum. When sombody
introduces a sync option which can co-exist with existing options,
they will need to use bit flags.


[..]
> > +               seq_puts(m, ",sync=fs");
> 
> option #1 (bitwise):
>        if (!ofs->config.sync)
>                seq_puts(m, ",sync=off");
>       else if (!OVL_SYNC_FILE(ofs->config.sync))
>                seq_puts(m, ",sync=fs");
> 
> option #2 (distinct):
> Would be better. See ovl_xino_str[].

Will do.

[..]
> > @@ -588,6 +608,17 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
> >                 config->workdir = NULL;
> >         }
> >
> > +       if (OVL_SYNC_OFF(config->sync) && OVL_SYNC_FS(config->sync)) {
> > +               pr_err("conflicting options: sync=off,sync=fs\n");
> > +               return -EINVAL;
> > +       }
> > +
> 
> We are not warning user that metacopy=off conflicts with metacopy=on,
> we just let the last option overwrite previous ones.

Ok, will drop this check.

Thanks
Vivek


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 21:50 [RFC PATCH v3] overlayfs: Provide mount options sync=off/fs to skip sync Vivek Goyal
2020-07-02  7:26 ` Amir Goldstein
2020-07-06 16:06   ` Vivek Goyal

($INBOX_DIR/description missing)

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-unionfs/0 linux-unionfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-unionfs linux-unionfs/ https://lore.kernel.org/linux-unionfs \
		linux-unionfs@vger.kernel.org
	public-inbox-index linux-unionfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-unionfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git