From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v4 5/9] ovl: mark overlayfs' inode dirty on shared mmap
Date: Fri, 13 Nov 2020 14:55:51 +0800 [thread overview]
Message-ID: <20201113065555.147276-6-cgxu519@mykernel.net> (raw)
In-Reply-To: <20201113065555.147276-1-cgxu519@mykernel.net>
Overlayfs cannot be notified when mmapped area gets dirty,
so we need to proactively mark inode dirty in ->mmap operation.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/overlayfs/file.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index efccb7c1f9bc..3f9de5343513 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -486,6 +486,9 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
/* Drop reference count from new vm_file value */
fput(realfile);
} else {
+ if (ovl_inode_upper(file_inode(file)) &&
+ vma->vm_flags & VM_SHARED)
+ ovl_mark_inode_dirty(file_inode(file));
/* Drop reference count from previous vm_file value */
fput(file);
}
--
2.26.2
next prev parent reply other threads:[~2020-11-13 6:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 6:55 [RFC PATCH v4 0/9] implement containerized syncfs for overlayfs Chengguang Xu
2020-11-13 6:55 ` [RFC PATCH v4 1/9] ovl: setup overlayfs' private bdi Chengguang Xu
2020-11-13 6:55 ` [RFC PATCH v4 2/9] ovl: implement ->writepages operation Chengguang Xu
2020-11-13 6:55 ` [RFC PATCH v4 3/9] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2020-11-13 6:55 ` [RFC PATCH v4 4/9] ovl: mark overlayfs' inode dirty on modification Chengguang Xu
2021-04-09 13:45 ` Miklos Szeredi
2021-04-12 11:58 ` Chengguang Xu
2020-11-13 6:55 ` Chengguang Xu [this message]
2020-11-13 6:55 ` [RFC PATCH v4 6/9] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2021-04-09 13:49 ` Miklos Szeredi
2021-04-14 6:14 ` Chengguang Xu
2020-11-13 6:55 ` [RFC PATCH v4 7/9] ovl: cache dirty overlayfs' inode Chengguang Xu
2021-04-09 13:50 ` Miklos Szeredi
2021-04-13 2:14 ` Chengguang Xu
2021-04-13 8:43 ` Miklos Szeredi
2021-04-14 5:53 ` Chengguang Xu
2020-11-13 6:55 ` [RFC PATCH v4 8/9] fs: export wait_sb_inodes() Chengguang Xu
2020-11-13 6:55 ` [RFC PATCH v4 9/9] ovl: implement containerized syncfs for overlayfs Chengguang Xu
2021-04-09 13:51 ` Miklos Szeredi
2021-04-12 12:24 ` Chengguang Xu
2021-04-12 14:22 ` Miklos Szeredi
2020-12-04 14:49 ` 回复:[RFC PATCH v4 0/9] " Chengguang Xu
2020-12-04 15:02 ` [RFC " Miklos Szeredi
2020-12-04 16:40 ` 回复:[RFC " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113065555.147276-6-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).