From: NeilBrown <neilb@suse.de>
To: Jeffrey Layton <jlayton@kernel.org>, Vivek Goyal <vgoyal@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-unionfs@vger.kernel.org, amir73il@gmail.com,
sargun@sargun.me, miklos@szeredi.hu, willy@infradead.org,
jack@suse.cz, neilb@suse.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()
Date: Sat, 19 Dec 2020 07:25:12 +1100 [thread overview]
Message-ID: <87sg82n9p3.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20201218165551.GA1178523@tleilax.poochiereds.net>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Fri, Dec 18 2020, Jeffrey Layton wrote:
>
> The patch we're discussing here _does_ add a f_op->syncfs, which is why
> I was suggesting to do it that way.
I haven't thought through the issues to decide what I think of adding a
new op, but I already know what I think of adding ->syncfs. Don't Do
It. The name is much too easily confused with ->sync_fs.
If you call it ->sync_fs_return_error() it would be MUCH better.
And having said that, the solution becomes obvious. Add a new flag,
either as another bit in 'int wait', or as a new bool.
The new flag would be "return_error" - or whatever is appropriate.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
prev parent reply other threads:[~2020-12-18 20:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 23:31 [RFC PATCH 0/3] vfs, overlayfs: Fix syncfs() to return error Vivek Goyal
2020-12-16 23:31 ` [PATCH 1/3] vfs: add new f_op->syncfs vector Vivek Goyal
2020-12-17 0:49 ` Al Viro
2020-12-17 9:57 ` Jan Kara
2020-12-17 16:15 ` Vivek Goyal
2020-12-17 15:00 ` Vivek Goyal
2020-12-17 19:49 ` Jeff Layton
2020-12-16 23:31 ` [PATCH 2/3] overlayfs: Implement f_op->syncfs() call Vivek Goyal
2020-12-16 23:31 ` [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs() Vivek Goyal
2020-12-17 20:08 ` Jeffrey Layton
2020-12-18 14:44 ` Vivek Goyal
2020-12-18 15:02 ` Jeff Layton
2020-12-18 16:28 ` Vivek Goyal
2020-12-18 16:55 ` Jeffrey Layton
2020-12-18 20:25 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg82n9p3.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.com \
--cc=sargun@sargun.me \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).