linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ovl: Fix some kernel-doc comments
@ 2022-06-01  2:28 Yang Li
  2022-07-27 13:21 ` Miklos Szeredi
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-06-01  2:28 UTC (permalink / raw)
  To: miklos; +Cc: linux-unionfs, linux-kernel, Yang Li, Abaci Robot

Remove warnings found by running scripts/kernel-doc,
which is caused by using 'make W=1'.
fs/overlayfs/super.c:311: warning: Function parameter or member 'dentry'
not described in 'ovl_statfs'
fs/overlayfs/super.c:311: warning: Excess function parameter 'sb'
description in 'ovl_statfs'
fs/overlayfs/super.c:357: warning: Function parameter or member 'm' not
described in 'ovl_show_options'
fs/overlayfs/super.c:357: warning: Function parameter or member 'dentry'
not described in 'ovl_show_options'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/overlayfs/super.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index e0a2e0468ee7..9282296dc4c9 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -301,7 +301,7 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
 
 /**
  * ovl_statfs
- * @sb: The overlayfs super block
+ * @dentry: The dentry to query
  * @buf: The struct kstatfs to fill in with stats
  *
  * Get the filesystem statistics.  As writes always target the upper layer
@@ -349,6 +349,8 @@ static inline int ovl_xino_def(void)
 
 /**
  * ovl_show_options
+ * @m: the seq_file handle
+ * @dentry: The dentry to query
  *
  * Prints the mount options for a given superblock.
  * Returns zero; does not fail.
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ovl: Fix some kernel-doc comments
  2022-06-01  2:28 [PATCH -next] ovl: Fix some kernel-doc comments Yang Li
@ 2022-07-27 13:21 ` Miklos Szeredi
  0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2022-07-27 13:21 UTC (permalink / raw)
  To: Yang Li; +Cc: overlayfs, linux-kernel, Abaci Robot

On Wed, 1 Jun 2022 at 04:28, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Remove warnings found by running scripts/kernel-doc,
> which is caused by using 'make W=1'.
> fs/overlayfs/super.c:311: warning: Function parameter or member 'dentry'
> not described in 'ovl_statfs'
> fs/overlayfs/super.c:311: warning: Excess function parameter 'sb'
> description in 'ovl_statfs'
> fs/overlayfs/super.c:357: warning: Function parameter or member 'm' not
> described in 'ovl_show_options'
> fs/overlayfs/super.c:357: warning: Function parameter or member 'dentry'
> not described in 'ovl_show_options'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Applied, thanks.

Miklos

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-27 13:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-01  2:28 [PATCH -next] ovl: Fix some kernel-doc comments Yang Li
2022-07-27 13:21 ` Miklos Szeredi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).