From: Miklos Szeredi <miklos@szeredi.hu>
To: "Christian Kohlschütter" <christian@kohlschutter.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ovl: Handle ENOSYS when fileattr support is missing in lower/upper fs
Date: Mon, 18 Jul 2022 14:21:16 +0200 [thread overview]
Message-ID: <CAJfpeguDAJpLMABsomBFQ=w6Li0=sBW0bFyALv4EJrAmR2BkpQ@mail.gmail.com> (raw)
In-Reply-To: <FFA26FD1-60EF-457E-B914-E1978CCC7B57@kohlschutter.com>
On Mon, 18 Jul 2022 at 12:56, Christian Kohlschütter
<christian@kohlschutter.com> wrote:
> However, users of fuse that have no business with overlayfs suddenly see their ioctl return ENOTTY instead of ENOSYS.
And returning ENOTTY is the correct behavior. See this comment in
<asm-generic/errrno.h>:
/*
* This error code is special: arch syscall entry code will return
* -ENOSYS if users try to call a syscall that doesn't exist. To keep
* failures of syscalls that really do exist distinguishable from
* failures due to attempts to use a nonexistent syscall, syscall
* implementations should refrain from returning -ENOSYS.
*/
#define ENOSYS 38 /* Invalid system call number */
Thanks,
Miklos
next prev parent reply other threads:[~2022-07-18 12:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 18:36 [PATCH] ovl: Handle ENOSYS when fileattr support is missing in lower/upper fs Christian Kohlschütter
2022-07-18 9:14 ` Miklos Szeredi
2022-07-18 10:10 ` Christian Kohlschütter
2022-07-18 10:31 ` Miklos Szeredi
2022-07-18 10:56 ` Christian Kohlschütter
2022-07-18 12:21 ` Miklos Szeredi [this message]
2022-07-18 13:03 ` [PATCH] [REGRESSION] " Christian Kohlschütter
2022-07-18 13:13 ` Miklos Szeredi
2022-07-18 14:25 ` Christian Kohlschütter
2022-07-18 15:02 ` Antonio SJ Musumeci
2022-07-18 17:23 ` Miklos Szeredi
2022-07-18 18:29 ` Linus Torvalds
2022-07-18 19:04 ` Christian Kohlschütter
2022-07-18 19:17 ` Linus Torvalds
2022-07-18 19:27 ` Miklos Szeredi
2022-07-18 20:12 ` Linus Torvalds
2022-07-18 20:33 ` Christian Kohlschütter
2023-01-18 3:41 ` Jonathan Katz
2023-01-26 13:26 ` Miklos Szeredi
2023-01-30 19:27 ` Jonathan Katz
2023-02-23 23:11 ` Jonathan Katz
2023-03-07 1:12 ` Jonathan Katz
2023-03-07 8:38 ` Miklos Szeredi
2023-03-07 17:14 ` Jonathan Katz
2023-03-09 15:31 ` Miklos Szeredi
2023-03-15 2:43 ` Jonathan Katz
2023-03-22 18:42 ` Jonathan Katz
2023-04-21 14:26 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpeguDAJpLMABsomBFQ=w6Li0=sBW0bFyALv4EJrAmR2BkpQ@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=christian@kohlschutter.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).