linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: "Yurkov, Vyacheslav" <Vyacheslav.Yurkov@bruker.com>
Cc: Vyacheslav Yurkov <uvv.mail@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] ovl: do not set overlay.opaque for new directories
Date: Tue, 1 Jun 2021 21:29:35 +0300	[thread overview]
Message-ID: <CAOQ4uxgGHw0WA407waFz2AShDGp9WMRLZjedKtcXNkS6hmvDhQ@mail.gmail.com> (raw)
In-Reply-To: <AM8PR10MB4161781D50CC2656A933D3CE863E9@AM8PR10MB4161.EURPRD10.PROD.OUTLOOK.COM>

On Tue, Jun 1, 2021 at 7:29 PM Yurkov, Vyacheslav
<Vyacheslav.Yurkov@bruker.com> wrote:
>
> Hi Amir,
> See below.
>
> > Maybe.
> > Failure of overlay/075 on master is known.
> > Failure of overlay/065 on master was fixed by xfstests commit
> > * 6159ae7f - overlay/065: Adapt test to relaxed rules
> > so you may want to update your xfstests copy.
>
> Using the latest master now, 065 is still failing for me.
>
> > Failure of overlay/005 is not familiar to me and the
> > attached log is missing all the output of the test -
> > it just has the summary.
>
> The reason was simple, it required xfs as underlying file system (and support in the kernel), but I had only ext4.
>
> > Worst yet, according to summary, all those test do not run in your setup:
> > Not run: overlay/001 overlay/004 overlay/008 overlay/015 overlay/020
> > overlay/021 overlay/025 overlay/032 overlay/045 overlay/046
> > overlay/056 overlay/064 overlay/100 overlay/101 overlay/102
> > overlay/103 overlay/104 overlay/105 overlay/106 overlay/107
> > overlay/108 overlay/109 overlay/110 overlay/111 overlay/112
> > overlay/113 overlay/114 overlay/115 overlay/116 overlay/117
> >
> > Can you provide the full log to understand the reason or figure it out yourself
> > and fix this.
> > If you are running a special setup that is fine, it doesn't have to
> > run all the test
> > (as long as you know why), but in order to verify that your patches did not
> > break other setups, you need to test with a common setup where all the
> > above tests run and pass, short of overlay/075 which is a known upstream
> > issue.
>
> It seems most of them require unionmount testsuite, which is not a part of xfstests package, and I missed your hint that I should check README.overlay ☹.
> Some of the other not-running tests needed more spaces (> 1GB), which I don't have on my device. And a few more required a dedicated user/group on the system.
>

Ok we still need to verify no regressions on those skipped test.
I can run them on my setup when I get the time if you cannot find
another test setup which meets the requirements.

> I added unionmount testsuite and sending my two test results.
>
> > > v2 indeed caused a few more failures on top of that:
> > > Failures: overlay/005 overlay/065 overlay/070 overlay/071 overlay/075
> > > Failed 5 of 93 tests
> > >
> >
> > I'm a bit surprised that tests overlay/068 overlay/069 did not fail with v2
> > Maybe they did not run and you did not notice that in the report?
>
> It did not indeed.
>
> Anyways, v3 results look pretty good now, I think.
>

Yes, looking better.

Thanks,
Amir.

  reply	other threads:[~2021-06-01 18:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 17:45 [PATCH v3 1/3] ovl: disable decoding null uuid with redirect dir Vyacheslav Yurkov
2021-05-27 17:45 ` [PATCH v3 2/3] ovl: add ovl_allow_offline_changes() helper Vyacheslav Yurkov
2021-05-27 17:45 ` [PATCH v3 3/3] ovl: do not set overlay.opaque for new directories Vyacheslav Yurkov
2021-05-28 11:38   ` Amir Goldstein
2021-06-01  6:53     ` Yurkov, Vyacheslav
2021-06-01  8:33       ` Amir Goldstein
2021-06-01 16:29         ` Yurkov, Vyacheslav
2021-06-01 18:29           ` Amir Goldstein [this message]
2021-06-04 12:32             ` Amir Goldstein
2021-06-04 14:50               ` Yurkov, Vyacheslav
2021-06-04 19:18                 ` Amir Goldstein
2021-07-19 14:29   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxgGHw0WA407waFz2AShDGp9WMRLZjedKtcXNkS6hmvDhQ@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=Vyacheslav.Yurkov@bruker.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=uvv.mail@gmail.com \
    --subject='Re: [PATCH v3 3/3] ovl: do not set overlay.opaque for new directories' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).