From: Lech Perczak <lech.perczak@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem
Date: Sat, 6 Feb 2021 15:50:41 +0100 [thread overview]
Message-ID: <0264f3a2-d974-c405-fb08-18e5ca21bf76@gmail.com> (raw)
In-Reply-To: <87r1lt1do6.fsf@miraculix.mork.no>
Hi,
W dniu 2021-02-06 o 15:19, Bjørn Mork pisze:
> Lech Perczak<lech.perczak@gmail.com> writes:
>
>> The modem is used inside ZTE MF283+ router and carriers identify it as
>> such.
>> Interface mapping is:
>> 0: QCDM, 1: AT (PCUI), 2: AT (Modem), 3: QMI, 4: ADB
>>
>> T: Bus=02 Lev=02 Prnt=02 Port=05 Cnt=01 Dev#= 3 Spd=480 MxCh= 0
>> D: Ver= 2.01 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
>> P: Vendor=19d2 ProdID=1275 Rev=f0.00
>> S: Manufacturer=ZTE,Incorporated
>> S: Product=ZTE Technologies MSM
>> S: SerialNumber=P685M510ZTED0000CP&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&0
> This lookes weird. But I guess that's really the string presented by
> this device?
Yes indeed. Looked weird to me too, but at least it confirms the model
name found in Windows drivers.
>> C:* #Ifs= 5 Cfg#= 1 Atr=a0 MxPwr=500mA
>> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
>> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
>> E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E: Ad=85(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
>> E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
>> E: Ad=87(I) Atr=03(Int.) MxPS= 8 Ivl=32ms
>> E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
>> E: Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>>
>> Cc: Bjørn Mork<bjorn@mork.no>
>> Signed-off-by: Lech Perczak<lech.perczak@gmail.com>
> Patch looks fine to me. But I don't think you can submit a net and usb
> serial patch in a series. These are two different subsystems.
>
> There's no dependency between the patches so you can just submit
> them as standalone patches. I.e. no series.
Actually, there is, and I just noticed, that patches are in wrong order.
Without patch 2/2 for 'option' driver, there is possibility for that
driver to steal
interface 3 from qmi_wwan, as currently it will match interface 3 as
ff/ff/ff.
With that in mind I'm not really sure how to proceed.
What comes to my mind, is either submit this as series again, with
ordering swapped,
or submit 2/2 first, wait for it to become merged, and then submit 1/2.
> Feel free to include
>
> Acked-by: Bjørn Mork<bjorn@mork.no>
Thank you.
--
With kind regards,
Lech
next prev parent reply other threads:[~2021-02-06 14:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 17:39 [PATCH v2 0/2] usb: add full support for ZTE P685M modem Lech Perczak
2021-02-05 17:39 ` [PATCH v2 1/2] net: usb: qmi_wwan: support " Lech Perczak
2021-02-06 14:19 ` Bjørn Mork
2021-02-06 14:50 ` Lech Perczak [this message]
2021-02-06 20:13 ` Jakub Kicinski
2021-02-07 0:54 ` [PATCH v3] usb: serial: option: update interface mapping for ZTE P685M Lech Perczak
2021-02-08 9:51 ` Johan Hovold
2021-02-08 9:35 ` [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem Johan Hovold
2021-02-08 17:52 ` Jakub Kicinski
2021-02-09 12:09 ` Johan Hovold
2021-02-23 18:34 ` [PATCH v3] " Lech Perczak
2021-02-24 18:10 ` patchwork-bot+netdevbpf
2021-03-01 21:13 ` Lech Perczak
2021-03-02 23:12 ` Jakub Kicinski
2021-02-05 17:39 ` [PATCH v2 2/2] usb: serial: option: add full support for ZTE P685M Lech Perczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0264f3a2-d974-c405-fb08-18e5ca21bf76@gmail.com \
--to=lech.perczak@gmail.com \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).