From: Johan Hovold <johan@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Lech Perczak" <lech.perczak@gmail.com>,
"Bjørn Mork" <bjorn@mork.no>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem
Date: Mon, 8 Feb 2021 10:35:24 +0100 [thread overview]
Message-ID: <YCEF3MY5Mau9TPvK@hovoldconsulting.com> (raw)
In-Reply-To: <20210206121322.074ddbd3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Sat, Feb 06, 2021 at 12:13:22PM -0800, Jakub Kicinski wrote:
> On Sat, 6 Feb 2021 15:50:41 +0100 Lech Perczak wrote:
> > >> Cc: Bjørn Mork<bjorn@mork.no>
> > >> Signed-off-by: Lech Perczak<lech.perczak@gmail.com>
> > > Patch looks fine to me. But I don't think you can submit a net and usb
> > > serial patch in a series. These are two different subsystems.
> > >
> > > There's no dependency between the patches so you can just submit
> > > them as standalone patches. I.e. no series.
> > Actually, there is, and I just noticed, that patches are in wrong order.
> > Without patch 2/2 for 'option' driver, there is possibility for that
> > driver to steal
> > interface 3 from qmi_wwan, as currently it will match interface 3 as
> > ff/ff/ff.
> >
> > With that in mind I'm not really sure how to proceed.
> >
> > What comes to my mind, is either submit this as series again, with
> > ordering swapped,
> > or submit 2/2 first, wait for it to become merged, and then submit 1/2.
>
> Send patch 2, wait for it to hit net, send 1 seems like the safest
> option. If we're lucky Johan can still send patch 2 for 5.11, otherwise
> we'll wait until the merge window - we're at rc7 already, it won't take
> too long.
I usually don't send on new device-ids this late in the release cycle,
so I'll queue the USB-serial one up for 5.12-rc1 and you can take this
one through net-next.
Johan
next prev parent reply other threads:[~2021-02-08 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 17:39 [PATCH v2 0/2] usb: add full support for ZTE P685M modem Lech Perczak
2021-02-05 17:39 ` [PATCH v2 1/2] net: usb: qmi_wwan: support " Lech Perczak
2021-02-06 14:19 ` Bjørn Mork
2021-02-06 14:50 ` Lech Perczak
2021-02-06 20:13 ` Jakub Kicinski
2021-02-07 0:54 ` [PATCH v3] usb: serial: option: update interface mapping for ZTE P685M Lech Perczak
2021-02-08 9:51 ` Johan Hovold
2021-02-08 9:35 ` Johan Hovold [this message]
2021-02-08 17:52 ` [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem Jakub Kicinski
2021-02-09 12:09 ` Johan Hovold
2021-02-23 18:34 ` [PATCH v3] " Lech Perczak
2021-02-24 18:10 ` patchwork-bot+netdevbpf
2021-03-01 21:13 ` Lech Perczak
2021-03-02 23:12 ` Jakub Kicinski
2021-02-05 17:39 ` [PATCH v2 2/2] usb: serial: option: add full support for ZTE P685M Lech Perczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCEF3MY5Mau9TPvK@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=kuba@kernel.org \
--cc=lech.perczak@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).