* [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()
@ 2021-03-24 0:02 Randy Dunlap
2021-03-24 23:32 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-03-24 0:02 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Valentina Manea, Shuah Khan, Shuah Khan, linux-usb
In list.h, the kernel-doc for list_del() should be immediately
preceding the implementation and not separated from it by
another function implementation.
Eliminates this kernel-doc error:
list.h:1: warning: 'list_del' not found
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Valentina Manea <valentina.manea.m@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
---
tools/usb/usbip/libsrc/list.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h
+++ linux-next-20210323/tools/usb/usbip/libsrc/list.h
@@ -77,17 +77,17 @@ static inline void __list_del(struct lis
#define LIST_POISON1 ((void *) 0x00100100 + POISON_POINTER_DELTA)
#define LIST_POISON2 ((void *) 0x00200200 + POISON_POINTER_DELTA)
+static inline void __list_del_entry(struct list_head *entry)
+{
+ __list_del(entry->prev, entry->next);
+}
+
/**
* list_del - deletes entry from list.
* @entry: the element to delete from the list.
* Note: list_empty() on entry does not return true after this, the entry is
* in an undefined state.
*/
-static inline void __list_del_entry(struct list_head *entry)
-{
- __list_del(entry->prev, entry->next);
-}
-
static inline void list_del(struct list_head *entry)
{
__list_del(entry->prev, entry->next);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()
2021-03-24 0:02 [PATCH] tools: usbip: list.h: fix kernel-doc for list_del() Randy Dunlap
@ 2021-03-24 23:32 ` Shuah Khan
2021-03-25 1:35 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2021-03-24 23:32 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Valentina Manea, Shuah Khan, linux-usb, Shuah Khan
On 3/23/21 6:02 PM, Randy Dunlap wrote:
> In list.h, the kernel-doc for list_del() should be immediately
> preceding the implementation and not separated from it by
> another function implementation.
>
> Eliminates this kernel-doc error:
> list.h:1: warning: 'list_del' not found
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Valentina Manea <valentina.manea.m@gmail.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> ---
> tools/usb/usbip/libsrc/list.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> --- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h
> +++ linux-next-20210323/tools/usb/usbip/libsrc/list.h
> @@ -77,17 +77,17 @@ static inline void __list_del(struct lis
> #define LIST_POISON1 ((void *) 0x00100100 + POISON_POINTER_DELTA)
> #define LIST_POISON2 ((void *) 0x00200200 + POISON_POINTER_DELTA)
>
> +static inline void __list_del_entry(struct list_head *entry)
> +{
> + __list_del(entry->prev, entry->next);
> +}
> +
> /**
> * list_del - deletes entry from list.
> * @entry: the element to delete from the list.
> * Note: list_empty() on entry does not return true after this, the entry is
> * in an undefined state.
> */
> -static inline void __list_del_entry(struct list_head *entry)
> -{
> - __list_del(entry->prev, entry->next);
> -}
> -
> static inline void list_del(struct list_head *entry)
> {
> __list_del(entry->prev, entry->next);
>
Thank you for fixing this.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()
2021-03-24 23:32 ` Shuah Khan
@ 2021-03-25 1:35 ` Randy Dunlap
2021-03-25 6:40 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-03-25 1:35 UTC (permalink / raw)
To: Shuah Khan, linux-kernel; +Cc: Valentina Manea, Shuah Khan, linux-usb
On 3/24/21 4:32 PM, Shuah Khan wrote:
> On 3/23/21 6:02 PM, Randy Dunlap wrote:
>> In list.h, the kernel-doc for list_del() should be immediately
>> preceding the implementation and not separated from it by
>> another function implementation.
>>
>> Eliminates this kernel-doc error:
>> list.h:1: warning: 'list_del' not found
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Valentina Manea <valentina.manea.m@gmail.com>
>> Cc: Shuah Khan <shuah@kernel.org>
>> Cc: Shuah Khan <skhan@linuxfoundation.org>
>> Cc: linux-usb@vger.kernel.org
>> ---
>> tools/usb/usbip/libsrc/list.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> --- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h
>> +++ linux-next-20210323/tools/usb/usbip/libsrc/list.h
>> @@ -77,17 +77,17 @@ static inline void __list_del(struct lis
>> #define LIST_POISON1 ((void *) 0x00100100 + POISON_POINTER_DELTA)
>> #define LIST_POISON2 ((void *) 0x00200200 + POISON_POINTER_DELTA)
>> +static inline void __list_del_entry(struct list_head *entry)
>> +{
>> + __list_del(entry->prev, entry->next);
>> +}
>> +
>> /**
>> * list_del - deletes entry from list.
>> * @entry: the element to delete from the list.
>> * Note: list_empty() on entry does not return true after this, the entry is
>> * in an undefined state.
>> */
>> -static inline void __list_del_entry(struct list_head *entry)
>> -{
>> - __list_del(entry->prev, entry->next);
>> -}
>> -
>> static inline void list_del(struct list_head *entry)
>> {
>> __list_del(entry->prev, entry->next);
>>
>
> Thank you for fixing this.
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Thanks. Who do you think should merge this patch?
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()
2021-03-25 1:35 ` Randy Dunlap
@ 2021-03-25 6:40 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-03-25 6:40 UTC (permalink / raw)
To: Randy Dunlap
Cc: Shuah Khan, linux-kernel, Valentina Manea, Shuah Khan, linux-usb
On Wed, Mar 24, 2021 at 06:35:01PM -0700, Randy Dunlap wrote:
> On 3/24/21 4:32 PM, Shuah Khan wrote:
> > On 3/23/21 6:02 PM, Randy Dunlap wrote:
> >> In list.h, the kernel-doc for list_del() should be immediately
> >> preceding the implementation and not separated from it by
> >> another function implementation.
> >>
> >> Eliminates this kernel-doc error:
> >> list.h:1: warning: 'list_del' not found
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Cc: Valentina Manea <valentina.manea.m@gmail.com>
> >> Cc: Shuah Khan <shuah@kernel.org>
> >> Cc: Shuah Khan <skhan@linuxfoundation.org>
> >> Cc: linux-usb@vger.kernel.org
> >> ---
> >> tools/usb/usbip/libsrc/list.h | 10 +++++-----
> >> 1 file changed, 5 insertions(+), 5 deletions(-)
> >>
> >> --- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h
> >> +++ linux-next-20210323/tools/usb/usbip/libsrc/list.h
> >> @@ -77,17 +77,17 @@ static inline void __list_del(struct lis
> >> #define LIST_POISON1 ((void *) 0x00100100 + POISON_POINTER_DELTA)
> >> #define LIST_POISON2 ((void *) 0x00200200 + POISON_POINTER_DELTA)
> >> +static inline void __list_del_entry(struct list_head *entry)
> >> +{
> >> + __list_del(entry->prev, entry->next);
> >> +}
> >> +
> >> /**
> >> * list_del - deletes entry from list.
> >> * @entry: the element to delete from the list.
> >> * Note: list_empty() on entry does not return true after this, the entry is
> >> * in an undefined state.
> >> */
> >> -static inline void __list_del_entry(struct list_head *entry)
> >> -{
> >> - __list_del(entry->prev, entry->next);
> >> -}
> >> -
> >> static inline void list_del(struct list_head *entry)
> >> {
> >> __list_del(entry->prev, entry->next);
> >>
> >
> > Thank you for fixing this.
> >
> > Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>
>
> Thanks. Who do you think should merge this patch?
I can :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-25 6:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 0:02 [PATCH] tools: usbip: list.h: fix kernel-doc for list_del() Randy Dunlap
2021-03-24 23:32 ` Shuah Khan
2021-03-25 1:35 ` Randy Dunlap
2021-03-25 6:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).