From: "Sandeep Maheswaram (Temp)" <sanm@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Doug Anderson <dianders@chromium.org>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Kaehlcke <mka@chromium.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings
Date: Wed, 8 Apr 2020 10:12:27 +0530 [thread overview]
Message-ID: <0b8d0d73-0421-bd4d-9dcc-62713c1c7f23@codeaurora.org> (raw)
In-Reply-To: <158631747937.216820.504748426462367724@swboyd.mtv.corp.google.com>
On 4/8/2020 9:14 AM, Stephen Boyd wrote:
> Quoting Sandeep Maheswaram (2020-03-26 00:06:07)
>> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> new file mode 100644
>> index 0000000..0f69475
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> @@ -0,0 +1,158 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +
> [...]
>> + maxItems: 1
>> +
>> + interrupts:
>> + items:
>> + - description: The interrupt that is asserted
>> + when a wakeup event is received on USB2 bus.
>> + - description: The interrupt that is asserted
>> + when a wakeup event is received on USB3 bus.
>> + - description: Wakeup event on DM line.
>> + - description: Wakeup event on DP line.
> I can see that it was optional before but that still doesn't make sense
> to me. The glue hardware from qcom always has interrupts so I'd expect
> it to be required in the binding.
Will add in next version.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-04-08 4:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:06 [PATCH v5 0/2] Add USB DWC3 support for SC7180 Sandeep Maheswaram
2020-03-26 7:06 ` [PATCH v5 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings Sandeep Maheswaram
2020-04-04 17:17 ` Rob Herring
2020-04-06 16:39 ` Sandeep Maheswaram (Temp)
2020-04-15 8:53 ` Sandeep Maheswaram (Temp)
2020-04-23 19:39 ` Matthias Kaehlcke
[not found] ` <64ce118c-2a8d-e16c-eed1-49350c8b07bc@codeaurora.org>
2020-05-13 16:04 ` Matthias Kaehlcke
2020-04-08 3:44 ` Stephen Boyd
2020-04-08 4:42 ` Sandeep Maheswaram (Temp) [this message]
2020-03-26 7:06 ` [PATCH v5 2/2] dt-bindings: usb: qcom,dwc3: Add compatible for SC7180 Sandeep Maheswaram
2020-03-29 10:27 ` [PATCH v5 0/2] Add USB DWC3 support " Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b8d0d73-0421-bd4d-9dcc-62713c1c7f23@codeaurora.org \
--to=sanm@codeaurora.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).