From: Matthias Kaehlcke <mka@chromium.org>
To: "Sandeep Maheswaram (Temp)" <sanm@codeaurora.org>
Cc: Rob Herring <robh@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings
Date: Thu, 23 Apr 2020 12:39:23 -0700 [thread overview]
Message-ID: <20200423193923.GK199755@google.com> (raw)
In-Reply-To: <5793ea62-7a73-789e-33d6-6b2fb37b376c@codeaurora.org>
On Wed, Apr 15, 2020 at 02:23:29PM +0530, Sandeep Maheswaram (Temp) wrote:
> Hi Rob,
>
> Any suggestions to solve this error in assigned-clock-rates
> On 4/6/2020 10:09 PM, Sandeep Maheswaram (Temp) wrote:
> > Hi Rob,
> >
> > On 4/4/2020 10:47 PM, Rob Herring wrote:
> > > On Thu, Mar 26, 2020 at 12:36:07PM +0530, Sandeep Maheswaram wrote:
> > > > Convert USB DWC3 bindings to DT schema format using json-schema.
> > > >
> > > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> > > > ---
> > > > .../devicetree/bindings/usb/qcom,dwc3.txt | 104
> > > > --------------
> > > > .../devicetree/bindings/usb/qcom,dwc3.yaml | 158
> > > > +++++++++++++++++++++
> > > > 2 files changed, 158 insertions(+), 104 deletions(-)
> > > > delete mode 100644
> > > > Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > > > b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > > > new file mode 100644
> > > > index 0000000..0f69475
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
...
> > > > + items:
> > > > + - description: Must be 19.2MHz (19200000).
> > > Sounds like a constraint:
> > >
> > > - const: 19200000
> > >
> > > > + - description: Must be >= 60 MHz in HS mode, >= 125 MHz
> > > > in SS mode.
> > > - minimum: 60000000
> > > maximum: ?
> >
> > Tried as below but facing errors
> >
> > assigned-clock-rates:
> > items:
> > - const: 19200000
> > - minimum: 60000000
> > maximum: 150000000
> >
> > Errors
> >
> > linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml:
> > usb@a6f8800: assigned-clock-rates: Additional items are not allowed
> > ([150000000] was unexpected)
> > linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml:
> > usb@a6f8800: assigned-clock-rates:0: [19200000] is too short
> > linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml:
> > usb@a6f8800: assigned-clock-rates: [[19200000], [150000000]] is too long
judging from the error messages my uneducated guess is that the above rules for
assigned-clock-rates expect a single tuple of two elements, not two tuples with
a single element, i.e.
assigned-clock-rates = <19200000, 150000000>;
instead of
assigned-clock-rates = <19200000>, <150000000>;
I experimented a bit but couldn't find the magic incantation to appease the
schema deities.
Rob, could you please help to distentangle this?
Thanks
Matthias
next prev parent reply other threads:[~2020-04-23 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:06 [PATCH v5 0/2] Add USB DWC3 support for SC7180 Sandeep Maheswaram
2020-03-26 7:06 ` [PATCH v5 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings Sandeep Maheswaram
2020-04-04 17:17 ` Rob Herring
2020-04-06 16:39 ` Sandeep Maheswaram (Temp)
2020-04-15 8:53 ` Sandeep Maheswaram (Temp)
2020-04-23 19:39 ` Matthias Kaehlcke [this message]
[not found] ` <64ce118c-2a8d-e16c-eed1-49350c8b07bc@codeaurora.org>
2020-05-13 16:04 ` Matthias Kaehlcke
2020-04-08 3:44 ` Stephen Boyd
2020-04-08 4:42 ` Sandeep Maheswaram (Temp)
2020-03-26 7:06 ` [PATCH v5 2/2] dt-bindings: usb: qcom,dwc3: Add compatible for SC7180 Sandeep Maheswaram
2020-03-29 10:27 ` [PATCH v5 0/2] Add USB DWC3 support " Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423193923.GK199755@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh@kernel.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).