From: Dmitry Osipenko <digetx@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Peter Chen <peter.chen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>, David Heidelberg <david@ixit.cz>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 08/12] power: supply: smb347-charger: Remove caching of charger state
Date: Sat, 17 Jul 2021 20:29:32 +0300 [thread overview]
Message-ID: <0df9fbf5-26fa-5d35-46d6-5c36567d6ed2@gmail.com> (raw)
In-Reply-To: <20210717162006.66cqkbw2mertd6tr@earth.universe>
17.07.2021 19:20, Sebastian Reichel пишет:
> Hi,
>
> On Sat, Jul 17, 2021 at 03:11:08PM +0300, Dmitry Osipenko wrote:
>> Regmap already provides us with the caching, so remove caching of charger
>> state to make code cleaner.
>
> cache_type is not initialized in smb347's regmap config and thus
> set to 0 = REGCACHE_NONE:
>
> static const struct regmap_config smb347_regmap = {
> .reg_bits = 8,
> .val_bits = 8,
> .max_register = SMB347_MAX_REGISTER,
> .volatile_reg = smb347_volatile_reg,
> .readable_reg = smb347_readable_reg,
> };
Good catch, thank you. I'll add patch to enable caching.
next prev parent reply other threads:[~2021-07-17 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 12:11 [PATCH v4 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7 Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 01/12] dt-bindings: phy: tegra20-usb-phy: Convert to schema Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 02/12] dt-bindings: phy: tegra20-usb-phy: Document properties needed for OTG mode Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 03/12] soc/tegra: pmc: Expose USB regmap to all SoCs Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 04/12] usb: phy: tegra: Support OTG mode programming Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 05/12] usb: otg-fsm: Fix hrtimer list corruption Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 07/12] power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 08/12] power: supply: smb347-charger: Remove caching of charger state Dmitry Osipenko
2021-07-17 16:20 ` Sebastian Reichel
2021-07-17 17:29 ` Dmitry Osipenko [this message]
2021-07-17 12:11 ` [PATCH v4 09/12] power: supply: smb347-charger: Implement USB VBUS regulator Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 10/12] ARM: tegra: Add new properties to USB PHY device-tree nodes Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 11/12] ARM: tegra: nexus7: Enable USB OTG mode Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 12/12] arm64: tegra132: Add new properties to USB PHY device-tree node Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0df9fbf5-26fa-5d35-46d6-5c36567d6ed2@gmail.com \
--to=digetx@gmail.com \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).