From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Peter Chen <peter.chen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>, David Heidelberg <david@ixit.cz>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 08/12] power: supply: smb347-charger: Remove caching of charger state
Date: Sat, 17 Jul 2021 18:20:06 +0200 [thread overview]
Message-ID: <20210717162006.66cqkbw2mertd6tr@earth.universe> (raw)
In-Reply-To: <20210717121112.3248-9-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]
Hi,
On Sat, Jul 17, 2021 at 03:11:08PM +0300, Dmitry Osipenko wrote:
> Regmap already provides us with the caching, so remove caching of charger
> state to make code cleaner.
cache_type is not initialized in smb347's regmap config and thus
set to 0 = REGCACHE_NONE:
static const struct regmap_config smb347_regmap = {
.reg_bits = 8,
.val_bits = 8,
.max_register = SMB347_MAX_REGISTER,
.volatile_reg = smb347_volatile_reg,
.readable_reg = smb347_readable_reg,
};
-- Sebastian
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/power/supply/smb347-charger.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c
> index db1378b41f80..f81c60c679a0 100644
> --- a/drivers/power/supply/smb347-charger.c
> +++ b/drivers/power/supply/smb347-charger.c
> @@ -135,7 +135,6 @@
> * @id: SMB charger ID
> * @mains_online: is AC/DC input connected
> * @usb_online: is USB input connected
> - * @charging_enabled: is charging enabled
> * @irq_unsupported: is interrupt unsupported by SMB hardware
> * @max_charge_current: maximum current (in uA) the battery can be charged
> * @max_charge_voltage: maximum voltage (in uV) the battery can be charged
> @@ -192,7 +191,6 @@ struct smb347_charger {
> unsigned int id;
> bool mains_online;
> bool usb_online;
> - bool charging_enabled;
> bool irq_unsupported;
>
> unsigned int max_charge_current;
> @@ -358,21 +356,13 @@ static int smb347_charging_status(struct smb347_charger *smb)
>
> static int smb347_charging_set(struct smb347_charger *smb, bool enable)
> {
> - int ret = 0;
> -
> if (smb->enable_control != SMB3XX_CHG_ENABLE_SW) {
> dev_dbg(smb->dev, "charging enable/disable in SW disabled\n");
> return 0;
> }
>
> - if (smb->charging_enabled != enable) {
> - ret = regmap_update_bits(smb->regmap, CMD_A, CMD_A_CHG_ENABLED,
> - enable ? CMD_A_CHG_ENABLED : 0);
> - if (!ret)
> - smb->charging_enabled = enable;
> - }
> -
> - return ret;
> + return regmap_update_bits(smb->regmap, CMD_A, CMD_A_CHG_ENABLED,
> + enable ? CMD_A_CHG_ENABLED : 0);
> }
>
> static inline int smb347_charging_enable(struct smb347_charger *smb)
> --
> 2.32.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-17 16:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 12:11 [PATCH v4 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7 Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 01/12] dt-bindings: phy: tegra20-usb-phy: Convert to schema Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 02/12] dt-bindings: phy: tegra20-usb-phy: Document properties needed for OTG mode Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 03/12] soc/tegra: pmc: Expose USB regmap to all SoCs Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 04/12] usb: phy: tegra: Support OTG mode programming Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 05/12] usb: otg-fsm: Fix hrtimer list corruption Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 07/12] power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 08/12] power: supply: smb347-charger: Remove caching of charger state Dmitry Osipenko
2021-07-17 16:20 ` Sebastian Reichel [this message]
2021-07-17 17:29 ` Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 09/12] power: supply: smb347-charger: Implement USB VBUS regulator Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 10/12] ARM: tegra: Add new properties to USB PHY device-tree nodes Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 11/12] ARM: tegra: nexus7: Enable USB OTG mode Dmitry Osipenko
2021-07-17 12:11 ` [PATCH v4 12/12] arm64: tegra132: Add new properties to USB PHY device-tree node Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210717162006.66cqkbw2mertd6tr@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).