From: Oliver Neukum <oneukum@suse.com>
To: Wenwen Wang <wenwen@cs.uga.edu>
Cc: "David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
"open list:USB NETWORKING DRIVERS" <linux-usb@vger.kernel.org>,
"open list:USB USBNET DRIVER FRAMEWORK" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: usbnet: fix a memory leak bug
Date: Thu, 15 Aug 2019 12:42:00 +0200 [thread overview]
Message-ID: <1565865720.5780.3.camel@suse.com> (raw)
In-Reply-To: <1565804493-7758-1-git-send-email-wenwen@cs.uga.edu>
Am Mittwoch, den 14.08.2019, 12:41 -0500 schrieb Wenwen Wang:
> In usbnet_start_xmit(), 'urb->sg' is allocated through kmalloc_array() by
> invoking build_dma_sg(). Later on, if 'CONFIG_PM' is defined and the if
> branch is taken, the execution will go to the label 'deferred'. However,
> 'urb->sg' is not deallocated on this execution path, leading to a memory
> leak bug.
Just to make this clear:
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
NACK
For the reason Jack explained. Deferral is not a failure.
Regards
Oliver
prev parent reply other threads:[~2019-08-15 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 17:41 [PATCH] net: usbnet: fix a memory leak bug Wenwen Wang
2019-08-14 21:32 ` Jack Pham
2019-08-15 10:42 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565865720.5780.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wenwen@cs.uga.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).