Patches to make multicast proccesing on CDC NCM drivers

Patches to make multicast proccesing on CDC NCM drivers

[Santiago Ruano Rincón]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

Hi,

Miguel Rodríguez sent this set of patches two years ago to fix the lack
of multicast processing on CDC NCM driver:

https://www.spinics.net/lists/linux-usb/msg170611.html
https://www.spinics.net/lists/linux-usb/msg170603.html
https://www.spinics.net/lists/linux-usb/msg170567.html
https://www.spinics.net/lists/linux-usb/msg170568.html

I've using a DKMS version of them, available in
https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
since more than a year ago, and they are working fine with my Dell D6000
docking station. IPv6 connectivity is broken without them.

Is there any chance to consider those patches (or what would be needed
to make it happen)?
It would be great to have them upstream!

See also: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1779173

Best regards,

 -- Santiago

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Patches to make multicast proccesing on CDC NCM drivers

[Oliver Neukum]

Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
Rincón:
> Hi,
> 
> Miguel Rodríguez sent this set of patches two years ago to fix the lack
> of multicast processing on CDC NCM driver:
> 
> https://www.spinics.net/lists/linux-usb/msg170611.html
> https://www.spinics.net/lists/linux-usb/msg170603.html
> https://www.spinics.net/lists/linux-usb/msg170567.html
> https://www.spinics.net/lists/linux-usb/msg170568.html
> 
> I've using a DKMS version of them, available in
> https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> since more than a year ago, and they are working fine with my Dell D6000
> docking station. IPv6 connectivity is broken without them.
> 
> Is there any chance to consider those patches (or what would be needed
> to make it happen)?
> It would be great to have them upstream!

Hi,

they have been merged on Wednesday.

	HTH
		Oliver

Re: Patches to make multicast proccesing on CDC NCM drivers

[Santiago Ruano Rincón]

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

El 30/07/20 a las 16:07, Oliver Neukum escribió:
> Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> Rincón:
> > Hi,
> > 
> > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > of multicast processing on CDC NCM driver:
> > 
> > https://www.spinics.net/lists/linux-usb/msg170611.html
> > https://www.spinics.net/lists/linux-usb/msg170603.html
> > https://www.spinics.net/lists/linux-usb/msg170567.html
> > https://www.spinics.net/lists/linux-usb/msg170568.html
> > 
> > I've using a DKMS version of them, available in
> > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > since more than a year ago, and they are working fine with my Dell D6000
> > docking station. IPv6 connectivity is broken without them.
> > 
> > Is there any chance to consider those patches (or what would be needed
> > to make it happen)?
> > It would be great to have them upstream!
> 
> Hi,
> 
> they have been merged on Wednesday.
…

Great, thanks!

It would be possible to apply/backport Miguel's patches (along with
5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?

FWIW, in the context of Debian, I'm personally interested in 4.19.y.

Best regards,

 -- Santiago

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Patches to make multicast proccesing on CDC NCM drivers

[Greg KH]

On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > Rincón:
> > > Hi,
> > > 
> > > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > > of multicast processing on CDC NCM driver:
> > > 
> > > https://www.spinics.net/lists/linux-usb/msg170611.html
> > > https://www.spinics.net/lists/linux-usb/msg170603.html
> > > https://www.spinics.net/lists/linux-usb/msg170567.html
> > > https://www.spinics.net/lists/linux-usb/msg170568.html
> > > 
> > > I've using a DKMS version of them, available in
> > > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > > since more than a year ago, and they are working fine with my Dell D6000
> > > docking station. IPv6 connectivity is broken without them.
> > > 
> > > Is there any chance to consider those patches (or what would be needed
> > > to make it happen)?
> > > It would be great to have them upstream!
> > 
> > Hi,
> > 
> > they have been merged on Wednesday.
> …
> 
> Great, thanks!
> 
> It would be possible to apply/backport Miguel's patches (along with
> 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?

I don't see that git commit id in Linus's tree, are you sure it is
correct?

> FWIW, in the context of Debian, I'm personally interested in 4.19.y.

What specific list of commits are you wanting to see backported?

thanks,

greg k-h

Re: Patches to make multicast proccesing on CDC NCM drivers

[Santiago Ruano Rincón]

[-- Attachment #1: Type: text/plain, Size: 1976 bytes --]

El 02/09/20 a las 14:05, Greg KH escribió:
> On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> > El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > > Rincón:
> > > > Hi,
> > > > 
> > > > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > > > of multicast processing on CDC NCM driver:
> > > > 
> > > > https://www.spinics.net/lists/linux-usb/msg170611.html
> > > > https://www.spinics.net/lists/linux-usb/msg170603.html
> > > > https://www.spinics.net/lists/linux-usb/msg170567.html
> > > > https://www.spinics.net/lists/linux-usb/msg170568.html
> > > > 
> > > > I've using a DKMS version of them, available in
> > > > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > > > since more than a year ago, and they are working fine with my Dell D6000
> > > > docking station. IPv6 connectivity is broken without them.
> > > > 
> > > > Is there any chance to consider those patches (or what would be needed
> > > > to make it happen)?
> > > > It would be great to have them upstream!
> > > 
> > > Hi,
> > > 
> > > they have been merged on Wednesday.
> > …
> > 
> > Great, thanks!
> > 
> > It would be possible to apply/backport Miguel's patches (along with
> > 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
> 
> I don't see that git commit id in Linus's tree, are you sure it is
> correct?

I should had mention it is found in linux-next, sorry. Please see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10

> > FWIW, in the context of Debian, I'm personally interested in 4.19.y.
> 
> What specific list of commits are you wanting to see backported?

This:

37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
e506addeff844237d60545ef4f6141de21471caf
0226009ce0f6089f9b31211f7a2703cf9a327a01

Thanks,

 -- santiago

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Patches to make multicast proccesing on CDC NCM drivers

[Greg KH]

On Wed, Sep 02, 2020 at 03:27:28PM +0200, Santiago Ruano Rincón wrote:
> El 02/09/20 a las 14:05, Greg KH escribió:
> > On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> > > El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > > > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > > > Rincón:
> > > > > Hi,
> > > > > 
> > > > > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > > > > of multicast processing on CDC NCM driver:
> > > > > 
> > > > > https://www.spinics.net/lists/linux-usb/msg170611.html
> > > > > https://www.spinics.net/lists/linux-usb/msg170603.html
> > > > > https://www.spinics.net/lists/linux-usb/msg170567.html
> > > > > https://www.spinics.net/lists/linux-usb/msg170568.html
> > > > > 
> > > > > I've using a DKMS version of them, available in
> > > > > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > > > > since more than a year ago, and they are working fine with my Dell D6000
> > > > > docking station. IPv6 connectivity is broken without them.
> > > > > 
> > > > > Is there any chance to consider those patches (or what would be needed
> > > > > to make it happen)?
> > > > > It would be great to have them upstream!
> > > > 
> > > > Hi,
> > > > 
> > > > they have been merged on Wednesday.
> > > …
> > > 
> > > Great, thanks!
> > > 
> > > It would be possible to apply/backport Miguel's patches (along with
> > > 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
> > 
> > I don't see that git commit id in Linus's tree, are you sure it is
> > correct?
> 
> I should had mention it is found in linux-next, sorry. Please see
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10

Ah, nothing I can do with patches that are not yet in Linus's tree.

> > > FWIW, in the context of Debian, I'm personally interested in 4.19.y.
> > 
> > What specific list of commits are you wanting to see backported?
> 
> This:
> 
> 37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
> e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
> e506addeff844237d60545ef4f6141de21471caf
> 0226009ce0f6089f9b31211f7a2703cf9a327a01

These do not look like bugfixes, but a new feature being added for this
driver.  So why not just use a newer kernel version for this feature?

thanks,

greg k-h

Re: Patches to make multicast proccesing on CDC NCM drivers

[Santiago Ruano Rincón]

[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]

El 02/09/20 a las 17:45, Greg KH escribió:
> On Wed, Sep 02, 2020 at 03:27:28PM +0200, Santiago Ruano Rincón wrote:
> > El 02/09/20 a las 14:05, Greg KH escribió:
> > > On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> > > > El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > > > > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > > > > Rincón:
…
> > > > 
> > > > It would be possible to apply/backport Miguel's patches (along with
> > > > 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
> > > 
> > > I don't see that git commit id in Linus's tree, are you sure it is
> > > correct?
> > 
> > I should had mention it is found in linux-next, sorry. Please see
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10
> 
> Ah, nothing I can do with patches that are not yet in Linus's tree.
> 

ACK.

> > > > FWIW, in the context of Debian, I'm personally interested in 4.19.y.
> > > 
> > > What specific list of commits are you wanting to see backported?
> > 
> > This:
> > 
> > 37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
> > e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
> > e506addeff844237d60545ef4f6141de21471caf
> > 0226009ce0f6089f9b31211f7a2703cf9a327a01
> 
> These do not look like bugfixes, but a new feature being added for this
> driver.  So why not just use a newer kernel version for this feature?

From my point of view as user these are bugfixes, since IPv6 NDP or any
other protocol relying on multicast do not work without them. In other
words, my computer's networking is broken.

I want to have them in linux stable releases because that would make
easier to include them in Debian stable release.

Thanks!

 -- Santiago

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Bug#965074: Patches to make multicast proccesing on CDC NCM drivers

[Bjørn Mork]

Santiago Ruano Rincón <santiago.ruano-rincon@imt-atlantique.fr> writes:
> El 02/09/20 a las 17:45, Greg KH escribió:
>> On Wed, Sep 02, 2020 at 03:27:28PM +0200, Santiago Ruano Rincón wrote:
>>
>> > This:
>> > 
>> > 37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
>> > e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
>> > e506addeff844237d60545ef4f6141de21471caf
>> > 0226009ce0f6089f9b31211f7a2703cf9a327a01
>> 
>> These do not look like bugfixes, but a new feature being added for this
>> driver.  So why not just use a newer kernel version for this feature?
>
> From my point of view as user these are bugfixes, since IPv6 NDP or any
> other protocol relying on multicast do not work without them. In other
> words, my computer's networking is broken.

I was in doubt when I submitted these, but ended up specfying net-next
instead of net+stable as the target for a reason.  This is a new feature
as Greg says. Even if the feature is essential for your use case, it is
still new. "Has never been supported" isn't really a bug.

And I am still convinced that my decision was correct.  The patches are
a bit more intrusive than I'd be comfortable submitting to stable, as
was demonstrated by the stupid build bug I added... Fixed by commit
5fd99b5d9950 ("net: cdc_ncm: Fix build error") BTW.

> I want to have them in linux stable releases because that would make
> easier to include them in Debian stable release.

This has not been an absolute requirement in the past. Distros tend to
have a more relaxed stable policy.

Using a newer kernel until Debian moves on is obviously also an option.



Bjørn