From: Li Jun <jun.li@nxp.com>
To: heikki.krogerus@linux.intel.com, robh+dt@kernel.org, rafael@kernel.org
Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
hdegoede@redhat.com, lee.jones@linaro.org,
mika.westerberg@linux.intel.com, dmitry.torokhov@gmail.com,
prabhakar.mahadev-lad.rj@bp.renesas.com,
laurent.pinchart+renesas@ideasonboard.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-imx@nxp.com, peter.chen@nxp.com
Subject: [PATCH v5 4/4] usb: typec: mux: add typec switch simple driver
Date: Tue, 3 Nov 2020 19:40:10 +0800 [thread overview]
Message-ID: <1604403610-16577-4-git-send-email-jun.li@nxp.com> (raw)
In-Reply-To: <1604403610-16577-1-git-send-email-jun.li@nxp.com>
This patch adds a simple typec switch driver for cases which only
needs some simple operations but a dedicated driver is required,
current driver only supports GPIO toggle to switch the super speed
active channel according to typec orientation.
Signed-off-by: Li Jun <jun.li@nxp.com>
---
Changes for v5:
- A few changes address Andy's comment, remove gpio check as it's
optional, add module name for Kconfig, use correct header files,
and other minor changes.
- Remove the mutex lock as it's not required currently.
Changes for v4:
- Change driver name to be switch simple from switch GPIO, to make it
generic for possible extention.
- Use compatiable "typec-orientation-switch" instead of bool property
for switch matching.
- Make acitve channel selection GPIO to be optional.
- Remove Andy's R-b tag since the driver changes a lot.
Change for v3:
- Remove file name in driver description.
- Add Andy Shevchenko's Reviewed-by tag.
Changes for v2:
- Use the correct head files for gpio api and of_device_id:
#include <linux/gpio/consumer.h>
#include <linux/mod_devicetable.h>
- Add driver dependency on GPIOLIB
drivers/usb/typec/mux/Kconfig | 10 ++++
drivers/usb/typec/mux/Makefile | 1 +
drivers/usb/typec/mux/switch-simple.c | 100 ++++++++++++++++++++++++++++++++++
3 files changed, 111 insertions(+)
diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
index a4dbd11..11320d7 100644
--- a/drivers/usb/typec/mux/Kconfig
+++ b/drivers/usb/typec/mux/Kconfig
@@ -18,4 +18,14 @@ config TYPEC_MUX_INTEL_PMC
control the USB role switch and also the multiplexer/demultiplexer
switches used with USB Type-C Alternate Modes.
+config TYPEC_SWITCH_SIMPLE
+ tristate "Type-C orientation switch simple driver"
+ depends on GPIOLIB
+ help
+ Say Y or M if your system need a simple driver for typec switch
+ control, like use GPIO to select active channel.
+
+ To compile this driver as a module, choose M here: the
+ module will be called switch-simple.
+
endmenu
diff --git a/drivers/usb/typec/mux/Makefile b/drivers/usb/typec/mux/Makefile
index 280a6f5..712d0ad 100644
--- a/drivers/usb/typec/mux/Makefile
+++ b/drivers/usb/typec/mux/Makefile
@@ -2,3 +2,4 @@
obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o
obj-$(CONFIG_TYPEC_MUX_INTEL_PMC) += intel_pmc_mux.o
+obj-$(CONFIG_TYPEC_SWITCH_SIMPLE) += switch-simple.o
diff --git a/drivers/usb/typec/mux/switch-simple.c b/drivers/usb/typec/mux/switch-simple.c
new file mode 100644
index 0000000..8707703
--- /dev/null
+++ b/drivers/usb/typec/mux/switch-simple.c
@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Type-C switch simple control driver
+ *
+ * Copyright 2020 NXP
+ * Author: Jun Li <jun.li@nxp.com>
+ */
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/mod_devicetable.h>
+#include <linux/mutex.h>
+#include <linux/platform_device.h>
+#include <linux/usb/typec_mux.h>
+
+struct typec_switch_simple {
+ struct typec_switch *sw;
+ struct gpio_desc *sel_gpio;
+};
+
+static int typec_switch_simple_set(struct typec_switch *sw,
+ enum typec_orientation orientation)
+{
+ struct typec_switch_simple *typec_sw = typec_switch_get_drvdata(sw);
+
+ switch (orientation) {
+ case TYPEC_ORIENTATION_NORMAL:
+ gpiod_set_value_cansleep(typec_sw->sel_gpio, 1);
+ break;
+ case TYPEC_ORIENTATION_REVERSE:
+ gpiod_set_value_cansleep(typec_sw->sel_gpio, 0);
+ break;
+ case TYPEC_ORIENTATION_NONE:
+ break;
+ }
+
+ return 0;
+}
+
+static int typec_switch_simple_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct typec_switch_desc sw_desc;
+ struct typec_switch_simple *typec_sw;
+
+ typec_sw = devm_kzalloc(dev, sizeof(*typec_sw), GFP_KERNEL);
+ if (!typec_sw)
+ return -ENOMEM;
+
+ platform_set_drvdata(pdev, typec_sw);
+
+ sw_desc.drvdata = typec_sw;
+ sw_desc.fwnode = dev->fwnode;
+ sw_desc.set = typec_switch_simple_set;
+
+ /* Get the super speed active channel selection GPIO */
+ typec_sw->sel_gpio = devm_gpiod_get_optional(dev, "switch", GPIOD_OUT_LOW);
+ if (IS_ERR(typec_sw->sel_gpio))
+ return PTR_ERR(typec_sw->sel_gpio);
+
+ typec_sw->sw = typec_switch_register(dev, &sw_desc);
+ if (IS_ERR(typec_sw->sw)) {
+ dev_err(dev, "Error registering typec switch: %ld\n",
+ PTR_ERR(typec_sw->sw));
+ return PTR_ERR(typec_sw->sw);
+ }
+
+ return 0;
+}
+
+static int typec_switch_simple_remove(struct platform_device *pdev)
+{
+ struct typec_switch_simple *typec_sw = platform_get_drvdata(pdev);
+
+ typec_switch_unregister(typec_sw->sw);
+
+ return 0;
+}
+
+static const struct of_device_id of_typec_switch_simple_match[] = {
+ { .compatible = "typec-orientation-switch" },
+ { /* Sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, of_typec_switch_simple_match);
+
+static struct platform_driver typec_switch_simple_driver = {
+ .probe = typec_switch_simple_probe,
+ .remove = typec_switch_simple_remove,
+ .driver = {
+ .name = "typec-switch-simple",
+ .of_match_table = of_typec_switch_simple_match,
+ },
+};
+
+module_platform_driver(typec_switch_simple_driver);
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("TypeC Orientation Switch Simple driver");
+MODULE_AUTHOR("Jun Li <jun.li@nxp.com>");
--
2.7.4
next prev parent reply other threads:[~2020-11-03 11:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:40 [PATCH v5 1/4] dt-bindings: usb: add documentation for typec switch simple driver Li Jun
2020-11-03 11:40 ` [PATCH v5 2/4] device property: Add fwnode_is_compatible() and device_is_compatible() helpers Li Jun
2020-11-03 11:40 ` [PATCH v5 3/4] usb: typec: mux: add "compatible" property for switch match Li Jun
2020-11-10 10:51 ` Heikki Krogerus
2020-11-03 11:40 ` Li Jun [this message]
2020-11-09 8:36 ` [PATCH v5 4/4] usb: typec: mux: add typec switch simple driver Heikki Krogerus
2020-11-24 1:56 ` Jun Li
2020-11-05 22:25 ` [PATCH v5 1/4] dt-bindings: usb: add documentation for " Rob Herring
2020-11-06 11:07 ` Jun Li
2020-11-06 14:24 ` Rob Herring
2020-11-09 12:24 ` Jun Li
2020-11-09 14:37 ` Rob Herring
2020-11-11 15:40 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604403610-16577-4-git-send-email-jun.li@nxp.com \
--to=jun.li@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).