From: Rob Herring <robh@kernel.org>
To: Li Jun <jun.li@nxp.com>
Cc: heikki.krogerus@linux.intel.com, rafael@kernel.org,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
hdegoede@redhat.com, lee.jones@linaro.org,
mika.westerberg@linux.intel.com, dmitry.torokhov@gmail.com,
prabhakar.mahadev-lad.rj@bp.renesas.com,
laurent.pinchart+renesas@ideasonboard.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-imx@nxp.com, peter.chen@nxp.com
Subject: Re: [PATCH v5 1/4] dt-bindings: usb: add documentation for typec switch simple driver
Date: Thu, 5 Nov 2020 16:25:59 -0600 [thread overview]
Message-ID: <20201105222559.GA1701705@bogus> (raw)
In-Reply-To: <1604403610-16577-1-git-send-email-jun.li@nxp.com>
On Tue, Nov 03, 2020 at 07:40:07PM +0800, Li Jun wrote:
> Some platforms need a simple driver to do some controls according to
> typec orientation, this can be extended to be a generic driver with
> compatible with "typec-orientation-switch".
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> No changes for v5.
>
> changes on v4:
> - Use compatible instead of bool property for switch matching.
> - Change switch GPIO to be switch simple.
> - Change the active channel selection GPIO to be optional.
>
> previous discussion:
> http://patchwork.ozlabs.org/patch/1054342/
>
> .../bindings/usb/typec-switch-simple.yaml | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/typec-switch-simple.yaml b/Documentation/devicetree/bindings/usb/typec-switch-simple.yaml
> new file mode 100644
> index 0000000..244162d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/typec-switch-simple.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/typec-switch-simple.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Typec Orientation Switch Simple Solution Bindings
> +
> +maintainers:
> + - Li Jun <jun.li@nxp.com>
> +
> +description: |-
> + USB SuperSpeed (SS) lanes routing to which side of typec connector is
> + decided by orientation, this maybe achieved by some simple control like
> + GPIO toggle.
> +
> +properties:
> + compatible:
> + const: typec-orientation-switch
> +
> + switch-gpios:
> + description: |
> + gpio specifier to switch the super speed active channel,
> + GPIO_ACTIVE_HIGH: GPIO state high for cc1;
> + GPIO_ACTIVE_LOW: GPIO state low for cc1.
What does active mean? There isn't really an active and inactive state,
right? It's more a mux selecting 0 or 1 input?
I think you want flags 0 (aka GPIO_ACTIVE_HIGH) unless there's an
inverter in the middle.
> + maxItems: 1
> +
> + port:
> + type: object
> + additionalProperties: false
> + description: -|
> + Connection to the remote endpoint using OF graph bindings that model SS
> + data bus to typec connector.
> +
> + properties:
> + endpoint:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + remote-endpoint: true
> +
> + required:
> + - remote-endpoint
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + ptn36043 {
> + compatible = "typec-orientation-switch";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ss_sel>;
> + switch-gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + usb3_data_ss: endpoint {
> + remote-endpoint = <&typec_con_ss>;
The data goes from the connector to here and then where? You need a
connection to the USB host controller.
> + };
> + };
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-11-05 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:40 [PATCH v5 1/4] dt-bindings: usb: add documentation for typec switch simple driver Li Jun
2020-11-03 11:40 ` [PATCH v5 2/4] device property: Add fwnode_is_compatible() and device_is_compatible() helpers Li Jun
2020-11-03 11:40 ` [PATCH v5 3/4] usb: typec: mux: add "compatible" property for switch match Li Jun
2020-11-10 10:51 ` Heikki Krogerus
2020-11-03 11:40 ` [PATCH v5 4/4] usb: typec: mux: add typec switch simple driver Li Jun
2020-11-09 8:36 ` Heikki Krogerus
2020-11-24 1:56 ` Jun Li
2020-11-05 22:25 ` Rob Herring [this message]
2020-11-06 11:07 ` [PATCH v5 1/4] dt-bindings: usb: add documentation for " Jun Li
2020-11-06 14:24 ` Rob Herring
2020-11-09 12:24 ` Jun Li
2020-11-09 14:37 ` Rob Herring
2020-11-11 15:40 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105222559.GA1701705@bogus \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).