* [PATCH] smsc95xx: fix stalled rx after link change
@ 2021-09-23 22:00 Aaro Koskinen
2021-09-24 13:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2021-09-23 22:00 UTC (permalink / raw)
To: Steve Glendinning, UNGLinuxDriver, David S. Miller,
Jakub Kicinski, Andre Edich, netdev, linux-usb
Cc: linux-kernel, Aaro Koskinen
After commit 05b35e7eb9a1 ("smsc95xx: add phylib support"), link changes
are no longer propagated to usbnet. As a result, rx URB allocation won't
happen until there is a packet sent out first (this might never happen,
e.g. running just ssh server with a static IP). Fix by triggering usbnet
EVENT_LINK_CHANGE.
Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/net/usb/smsc95xx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 7d953974eb9b..26b1bd8e845b 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -1178,7 +1178,10 @@ static void smsc95xx_unbind(struct usbnet *dev, struct usb_interface *intf)
static void smsc95xx_handle_link_change(struct net_device *net)
{
+ struct usbnet *dev = netdev_priv(net);
+
phy_print_status(net->phydev);
+ usbnet_defer_kevent(dev, EVENT_LINK_CHANGE);
}
static int smsc95xx_start_phy(struct usbnet *dev)
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] smsc95xx: fix stalled rx after link change
2021-09-23 22:00 [PATCH] smsc95xx: fix stalled rx after link change Aaro Koskinen
@ 2021-09-24 13:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-24 13:20 UTC (permalink / raw)
To: Aaro Koskinen
Cc: steve.glendinning, UNGLinuxDriver, davem, kuba, andre.edich,
netdev, linux-usb, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 24 Sep 2021 01:00:16 +0300 you wrote:
> After commit 05b35e7eb9a1 ("smsc95xx: add phylib support"), link changes
> are no longer propagated to usbnet. As a result, rx URB allocation won't
> happen until there is a packet sent out first (this might never happen,
> e.g. running just ssh server with a static IP). Fix by triggering usbnet
> EVENT_LINK_CHANGE.
>
> Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> [...]
Here is the summary with links:
- smsc95xx: fix stalled rx after link change
https://git.kernel.org/netdev/net/c/5ab8a447bcfe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-24 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 22:00 [PATCH] smsc95xx: fix stalled rx after link change Aaro Koskinen
2021-09-24 13:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).