linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] lan78xx: select CRC32
@ 2021-10-15 13:07 Vegard Nossum
  2021-10-15 13:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Vegard Nossum @ 2021-10-15 13:07 UTC (permalink / raw)
  To: Woojung Huh, UNGLinuxDriver, Jakub Kicinski
  Cc: David S. Miller, netdev, linux-usb, linux-kernel, Vegard Nossum

Fix the following build/link error by adding a dependency on the CRC32
routines:

  ld: drivers/net/usb/lan78xx.o: in function `lan78xx_set_multicast':
  lan78xx.c:(.text+0x48cf): undefined reference to `crc32_le'

The actual use of crc32_le() comes indirectly through ether_crc().

Fixes: 55d7de9de6c30 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
 drivers/net/usb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index f87f175033731..b554054a7560a 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -117,6 +117,7 @@ config USB_LAN78XX
 	select PHYLIB
 	select MICROCHIP_PHY
 	select FIXED_PHY
+	select CRC32
 	help
 	  This option adds support for Microchip LAN78XX based USB 2
 	  & USB 3 10/100/1000 Ethernet adapters.
-- 
2.23.0.718.g5ad94255a8


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] lan78xx: select CRC32
  2021-10-15 13:07 [PATCH] lan78xx: select CRC32 Vegard Nossum
@ 2021-10-15 13:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-15 13:40 UTC (permalink / raw)
  To: Vegard Nossum
  Cc: woojung.huh, UNGLinuxDriver, kuba, davem, netdev, linux-usb,
	linux-kernel

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 15 Oct 2021 15:07:54 +0200 you wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
> 
>   ld: drivers/net/usb/lan78xx.o: in function `lan78xx_set_multicast':
>   lan78xx.c:(.text+0x48cf): undefined reference to `crc32_le'
> 
> The actual use of crc32_le() comes indirectly through ether_crc().
> 
> [...]

Here is the summary with links:
  - lan78xx: select CRC32
    https://git.kernel.org/netdev/net/c/46393d61a328

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-15 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 13:07 [PATCH] lan78xx: select CRC32 Vegard Nossum
2021-10-15 13:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).