* [PATCH] usb: plusb: remove unused pl_clear_QuickLink_features function
@ 2023-03-18 13:13 Tom Rix
2023-03-20 10:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-18 13:13 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, nathan, ndesaulniers, stern,
studentxswpy, gregkh
Cc: linux-usb, netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/net/usb/plusb.c:65:1: error:
unused function 'pl_clear_QuickLink_features' [-Werror,-Wunused-function]
pl_clear_QuickLink_features(struct usbnet *dev, int val)
^
This static function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/usb/plusb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c
index 7a2b0094de51..2894114858a2 100644
--- a/drivers/net/usb/plusb.c
+++ b/drivers/net/usb/plusb.c
@@ -61,12 +61,6 @@ pl_vendor_req(struct usbnet *dev, u8 req, u8 val, u8 index)
val, index, NULL, 0);
}
-static inline int
-pl_clear_QuickLink_features(struct usbnet *dev, int val)
-{
- return pl_vendor_req(dev, 1, (u8) val, 0);
-}
-
static inline int
pl_set_QuickLink_features(struct usbnet *dev, int val)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: plusb: remove unused pl_clear_QuickLink_features function
2023-03-18 13:13 [PATCH] usb: plusb: remove unused pl_clear_QuickLink_features function Tom Rix
@ 2023-03-20 10:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-20 10:20 UTC (permalink / raw)
To: Tom Rix
Cc: davem, edumazet, kuba, pabeni, nathan, ndesaulniers, stern,
studentxswpy, gregkh, linux-usb, netdev, linux-kernel, llvm
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Sat, 18 Mar 2023 09:13:42 -0400 you wrote:
> clang with W=1 reports
> drivers/net/usb/plusb.c:65:1: error:
> unused function 'pl_clear_QuickLink_features' [-Werror,-Wunused-function]
> pl_clear_QuickLink_features(struct usbnet *dev, int val)
> ^
> This static function is not used, so remove it.
>
> [...]
Here is the summary with links:
- usb: plusb: remove unused pl_clear_QuickLink_features function
https://git.kernel.org/netdev/net/c/7d722c9802d4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-18 13:13 [PATCH] usb: plusb: remove unused pl_clear_QuickLink_features function Tom Rix
2023-03-20 10:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).